Re: [PATCH] soc: imx: gpcv2: fix regulator deferred probe

From	Shawn Guo <shawnguo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] soc: imx: gpcv2: fix regulator deferred probe
Date	2017-08-14 07:40 +0200
Message-ID	<ueggy-7f-9@gated-at.bofh.it> (permalink)
References	<ua7Yd-5TV-3@gated-at.bofh.it> <uaXN7-7Ew-1@gated-at.bofh.it> <uefXb-8sK-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Aug 13, 2017 at 10:12:13PM -0700, Stefan Agner wrote:
> Hi Shawn,
> 
> On 2017-08-04 20:13, Shawn Guo wrote:
> > On Wed, Aug 02, 2017 at 12:51:29PM -0700, Stefan Agner wrote:
> >> If a regulator requests a deferred probe, the power domain gets
> >> initialized twice. This leads to a list double add (without
> >> list debugging the kernel hangs due to the double add later):
> >>
> >>   WARNING: CPU: 0 PID: 19 at lib/list_debug.c:31 __list_add_valid+0xbc/0xc4
> >>   list_add double add: new=c1229754, prev=c12383b4, next=c1229754.
> >>
> >> Initialize the power domain after we get the regulator. Also do
> >> not print an error in case the regulator defers probing.
> >>
> >> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> >> Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
> >> Cc: linux-arm-kernel@lists.infradead.org
> >> Cc: linux-kernel@vger.kernel.org
> >> Fixes: 03aa12629fc4 ("soc: imx: Add GPCv2 power gating driver")
> >> Signed-off-by: Stefan Agner <stefan@agner.ch>
> > 
> > Applied, thanks.
> 
> As of 4.13-rc5 this did not make it upstream yet, I guess still on its
> way?

Yes, Stefan. It's on the way to arm-soc [1], but not yet responded.

Shawn

[1] https://www.spinics.net/lists/arm-kernel/msg598634.html

Thread

Re: [PATCH] soc: imx: gpcv2: fix regulator deferred probe Stefan Agner <stefan@agner.ch> - 2017-08-14 07:20 +0200
  Re: [PATCH] soc: imx: gpcv2: fix regulator deferred probe Shawn Guo <shawnguo@kernel.org> - 2017-08-14 07:40 +0200
    Re: [PATCH] soc: imx: gpcv2: fix regulator deferred probe Arnd Bergmann <arnd@arndb.de> - 2017-08-15 17:40 +0200

csiph-web