[PATCH] crypto: cavium/nitrox - Fix an error handling path in 'nitrox_probe()'

From	Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Newsgroups	linux.kernel
Subject	[PATCH] crypto: cavium/nitrox - Fix an error handling path in 'nitrox_probe()'
Date	2017-08-16 07:20 +0200
Message-ID	<ueYUh-2Ut-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

'err' is known to be 0 at this point.
If 'kzalloc()' fails, returns -ENOMEM instead of 0 which means success.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/crypto/cavium/nitrox/nitrox_main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/cavium/nitrox/nitrox_main.c b/drivers/crypto/cavium/nitrox/nitrox_main.c
index 9ccefb9b7232..fee7cb2ce747 100644
--- a/drivers/crypto/cavium/nitrox/nitrox_main.c
+++ b/drivers/crypto/cavium/nitrox/nitrox_main.c
@@ -513,8 +513,10 @@ static int nitrox_probe(struct pci_dev *pdev,
 	pci_set_master(pdev);
 
 	ndev = kzalloc(sizeof(*ndev), GFP_KERNEL);
-	if (!ndev)
+	if (!ndev) {
+		err = -ENOMEM;
 		goto ndev_fail;
+	}
 
 	pci_set_drvdata(pdev, ndev);
 	ndev->pdev = pdev;
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] crypto: cavium/nitrox - Fix an error handling path in 'nitrox_probe()' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-08-16 07:20 +0200
  Re: [PATCH] crypto: cavium/nitrox - Fix an error handling path in  'nitrox_probe()' Herbert Xu <herbert@gondor.apana.org.au> - 2017-08-22 10:00 +0200

csiph-web