Re: [PATCH v2] zsmalloc: zs_page_migrate: schedule free_work if zspage is ZS_EMPTY

From	Minchan Kim <minchan@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] zsmalloc: zs_page_migrate: schedule free_work if zspage is ZS_EMPTY
Date	2017-08-16 07:00 +0200
Message-ID	<ueYAV-2vJ-5@gated-at.bofh.it> (permalink)
References	<uekka-2xb-33@gated-at.bofh.it> <ueW66-17t-5@gated-at.bofh.it> <ueWz7-1gX-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 16, 2017 at 10:49:14AM +0800, Hui Zhu wrote:
> Hi Minchan,
> 
> 2017-08-16 10:13 GMT+08:00 Minchan Kim <minchan@kernel.org>:
> > Hi Hui,
> >
> > On Mon, Aug 14, 2017 at 05:56:30PM +0800, Hui Zhu wrote:
> >> After commit e2846124f9a2 ("zsmalloc: zs_page_migrate: skip unnecessary
> >
> > This patch is not merged yet so the hash is invalid.
> > That means we may fold this patch to [1] in current mmotm.
> >
> > [1] zsmalloc-zs_page_migrate-skip-unnecessary-loops-but-not-return-ebusy-if-zspage-is-not-inuse-fix.patch
> >
> >> loops but not return -EBUSY if zspage is not inuse") zs_page_migrate
> >> can handle the ZS_EMPTY zspage.
> >>
> >> But I got some false in zs_page_isolate:
> >>       if (get_zspage_inuse(zspage) == 0) {
> >>               spin_unlock(&class->lock);
> >>               return false;
> >>       }
> >
> > I also realized we should make zs_page_isolate succeed on empty zspage
> > because we allow the empty zspage migration from now on.
> > Could you send a patch for that as well?
> 
> OK.  I will make a patch for that later.

Please send the patch so I want to fold it to [1] before Andrew is going
to send [1] to Linus.

Thanks.

Thread

[PATCH v2] zsmalloc: zs_page_migrate: schedule free_work if zspage is ZS_EMPTY Hui Zhu <zhuhui@xiaomi.com> - 2017-08-14 12:00 +0200
  Re: [PATCH v2] zsmalloc: zs_page_migrate: schedule free_work if  zspage is ZS_EMPTY Minchan Kim <minchan@kernel.org> - 2017-08-16 04:20 +0200
    Re: [PATCH v2] zsmalloc: zs_page_migrate: schedule free_work if  zspage is ZS_EMPTY Hui Zhu <teawater@gmail.com> - 2017-08-16 04:50 +0200
      Re: [PATCH v2] zsmalloc: zs_page_migrate: schedule free_work if  zspage is ZS_EMPTY Minchan Kim <minchan@kernel.org> - 2017-08-16 07:00 +0200
        Re: [PATCH v2] zsmalloc: zs_page_migrate: schedule free_work if  zspage is ZS_EMPTY Hui Zhu <teawater@gmail.com> - 2017-08-16 10:20 +0200

csiph-web