Re: [PATCH net-next V2 1/3] tap: use build_skb() for small packet

From	Jason Wang <jasowang@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next V2 1/3] tap: use build_skb() for small packet
Date	2017-08-16 06:10 +0200
Message-ID	<ueXOx-2cs-7@gated-at.bofh.it> (permalink)
References	(1 earlier) <udgC0-315-65@gated-at.bofh.it> <ueXvc-1Rc-11@gated-at.bofh.it> <ueXER-1Uj-5@gated-at.bofh.it> <ueXER-1Uj-3@gated-at.bofh.it> <ueXER-1Uj-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 2017年08月16日 11:59, Michael S. Tsirkin wrote:
> On Wed, Aug 16, 2017 at 11:57:51AM +0800, Jason Wang wrote:
>>
>> On 2017年08月16日 11:55, Michael S. Tsirkin wrote:
>>> On Tue, Aug 15, 2017 at 08:45:20PM -0700, Eric Dumazet wrote:
>>>> On Fri, 2017-08-11 at 19:41 +0800, Jason Wang wrote:
>>>>> We use tun_alloc_skb() which calls sock_alloc_send_pskb() to allocate
>>>>> skb in the past. This socket based method is not suitable for high
>>>>> speed userspace like virtualization which usually:
>>>>>
>>>>> - ignore sk_sndbuf (INT_MAX) and expect to receive the packet as fast as
>>>>>     possible
>>>>> - don't want to be block at sendmsg()
>>>>>
>>>>> To eliminate the above overheads, this patch tries to use build_skb()
>>>>> for small packet. We will do this only when the following conditions
>>>>> are all met:
>>>>>
>>>>> - TAP instead of TUN
>>>>> - sk_sndbuf is INT_MAX
>>>>> - caller don't want to be blocked
>>>>> - zerocopy is not used
>>>>> - packet size is smaller enough to use build_skb()
>>>>>
>>>>> Pktgen from guest to host shows ~11% improvement for rx pps of tap:
>>>>>
>>>>> Before: ~1.70Mpps
>>>>> After : ~1.88Mpps
>>>>>
>>>>> What's more important, this makes it possible to implement XDP for tap
>>>>> before creating skbs.
>>>> Well well well.
>>>>
>>>> You do realize that tun_build_skb() is not thread safe ?
>>> The issue is alloc frag, isn't it?
>>> I guess for now we can limit this to XDP mode only, and
>>> just allocate full pages in that mode.
>>>
>>>
>> Limit this to XDP mode only does not prevent user from sending packets to
>> same queue in parallel I think?
>>
>> Thanks
> Yes but then you can just drop the page frag allocator since
> XDP is assumed not to care about truesize for most packets.
>

Ok, let me do some test to see the numbers between the two methods first.

Thanks

Thread

Re: [PATCH net-next V2 1/3] tap: use build_skb() for small packet Eric Dumazet <eric.dumazet@gmail.com> - 2017-08-16 05:50 +0200
  Re: [PATCH net-next V2 1/3] tap: use build_skb() for small packet Jason Wang <jasowang@redhat.com> - 2017-08-16 06:00 +0200
    Re: [PATCH net-next V2 1/3] tap: use build_skb() for small packet "Michael S. Tsirkin" <mst@redhat.com> - 2017-08-16 06:00 +0200
      Re: [PATCH net-next V2 1/3] tap: use build_skb() for small packet Jason Wang <jasowang@redhat.com> - 2017-08-16 06:10 +0200
        Re: [PATCH net-next V2 1/3] tap: use build_skb() for small packet Jason Wang <jasowang@redhat.com> - 2017-08-16 11:20 +0200
          Re: [PATCH net-next V2 1/3] tap: use build_skb() for small packet David Miller <davem@davemloft.net> - 2017-08-16 18:40 +0200
  Re: [PATCH net-next V2 1/3] tap: use build_skb() for small packet Jason Wang <jasowang@redhat.com> - 2017-08-16 06:00 +0200
    Re: [PATCH net-next V2 1/3] tap: use build_skb() for small packet Eric Dumazet <eric.dumazet@gmail.com> - 2017-08-16 12:30 +0200
      Re: [PATCH net-next V2 1/3] tap: use build_skb() for small packet Jason Wang <jasowang@redhat.com> - 2017-08-16 15:20 +0200
  Re: [PATCH net-next V2 1/3] tap: use build_skb() for small packet "Michael S. Tsirkin" <mst@redhat.com> - 2017-08-16 06:00 +0200

csiph-web