Re: [PATCH 2/2] Revert "pstore: Honor dmesg_restrict sysctl on dmesg dumps"

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] Revert "pstore: Honor dmesg_restrict sysctl on dmesg dumps"
Date	2017-08-16 02:40 +0200
Message-ID	<ueUxj-8pZ-1@gated-at.bofh.it> (permalink)
References	<ud2pk-2qz-5@gated-at.bofh.it> <ud2pk-2qz-21@gated-at.bofh.it> <ueUnE-8n1-19@gated-at.bofh.it> <ueUnE-8n1-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 15 Aug 2017 17:29:38 -0700
Kees Cook <keescook@chromium.org> wrote:

> On Tue, Aug 15, 2017 at 5:21 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > On Thu, 10 Aug 2017 13:36:35 -0700
> > Kees Cook <keescook@chromium.org> wrote:
> >  
> >> This reverts commit 68c4a4f8abc60c9440ede9cd123d48b78325f7a3, with
> >> various conflict clean-ups.
> >>
> >> With the default root directory mode set to 0750 now, the capability
> >> check was redundant.  
> >
> > What's wrong with redundancy?  
> 
> In this case, it actually _blocks_ system builders from being able to
> define the access controls on pstore. :(

Then that should be stated in the change log, as it is the real reason
to revert, not just the fact that it is redundant.

Thanks,

-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] Revert "pstore: Honor dmesg_restrict sysctl on  dmesg dumps" Steven Rostedt <rostedt@goodmis.org> - 2017-08-16 02:30 +0200
  Re: [PATCH 2/2] Revert "pstore: Honor dmesg_restrict sysctl on dmesg dumps" Kees Cook <keescook@chromium.org> - 2017-08-16 02:30 +0200
    Re: [PATCH 2/2] Revert "pstore: Honor dmesg_restrict sysctl on  dmesg dumps" Steven Rostedt <rostedt@goodmis.org> - 2017-08-16 02:40 +0200

csiph-web