Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1712520

[patch 1/2] mm, compaction: kcompactd should not ignore pageblock skip

Show all headers | View raw

Kcompactd is needlessly ignoring pageblock skip information.  It is doing
MIGRATE_SYNC_LIGHT compaction, which is no more powerful than
MIGRATE_SYNC compaction.

If compaction recently failed to isolate memory from a set of pageblocks,
there is nothing to indicate that kcompactd will be able to do so, or
that it is beneficial from attempting to isolate memory.

Use the pageblock skip hint to avoid rescanning pageblocks needlessly
until that information is reset.

Signed-off-by: David Rientjes <rientjes@google.com>
---
 mm/compaction.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mm/compaction.c b/mm/compaction.c
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1927,9 +1927,8 @@ static void kcompactd_do_work(pg_data_t *pgdat)
 		.total_free_scanned = 0,
 		.classzone_idx = pgdat->kcompactd_classzone_idx,
 		.mode = MIGRATE_SYNC_LIGHT,
-		.ignore_skip_hint = true,
+		.ignore_skip_hint = false,
 		.gfp_mask = GFP_KERNEL,
-
 	};
 	trace_mm_compaction_kcompactd_wake(pgdat->node_id, cc.order,
 							cc.classzone_idx);

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[patch 1/2] mm, compaction: kcompactd should not ignore pageblock  skip David Rientjes <rientjes@google.com> - 2017-08-16 01:40 +0200
  [patch 2/2] mm, compaction: persistently skip hugetlbfs pageblocks David Rientjes <rientjes@google.com> - 2017-08-16 01:40 +0200
    Re: [patch 2/2] mm, compaction: persistently skip hugetlbfs  pageblocks Michal Hocko <mhocko@kernel.org> - 2017-08-18 10:50 +0200
      [patch -mm] mm, compaction: persistently skip hugetlbfs pageblocks  fix David Rientjes <rientjes@google.com> - 2017-08-21 02:40 +0200
        Re: [patch -mm] mm, compaction: persistently skip hugetlbfs  pageblocks fix Michal Hocko <mhocko@kernel.org> - 2017-08-21 08:40 +0200
    Re: [patch 2/2] mm, compaction: persistently skip hugetlbfs  pageblocks Vlastimil Babka <vbabka@suse.cz> - 2017-08-23 10:50 +0200
  Re: [patch 1/2] mm, compaction: kcompactd should not ignore pageblock  skip Vlastimil Babka <vbabka@suse.cz> - 2017-08-23 10:30 +0200

csiph-web