Re: [PATCH] Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile

From	Randy Dunlap <rdunlap@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile
Date	2017-08-15 20:00 +0200
Message-ID	<ueOid-4oS-1@gated-at.bofh.it> (permalink)
References	<ueJLA-1Ix-23@gated-at.bofh.it> <ueKxX-1YZ-1@gated-at.bofh.it> <ueNcu-3Ii-15@gated-at.bofh.it> <ueNYS-4hU-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/15/2017 10:36 AM, David Miller wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> Date: Tue, 15 Aug 2017 09:41:53 -0700
> 
>> On 08/15/2017 06:51 AM, Neal Cardwell wrote:
>>> On Tue, Aug 15, 2017 at 9:08 AM, mohamedalrshah
>>> <mohamed.a.alrshah@ieee.org> wrote:
>>>
>>>> +static void agilesdtcp_cong_avoid(struct sock *sk, u32 ack, u32 in_flight)
>>>> +{
>>>> +       struct tcp_sock *tp = tcp_sk(sk);
>>>> +       struct agilesdtcp *ca = inet_csk_ca(sk);
>>>> +       u32 inc_factor;
>>>> +       u32 ca_inc;
>>>> +       u32 current_gap, total_gap;
>>>
>>> For coding style, please order local variable declarations from
>>> longest to shortest line, also know as Reverse Christmas Tree Format.
>>
>> Per what coding style, please?  This is not in current coding style nor in the
>> netdev-FAQ exceptions.
> 
> It is the established practice, documented or not, and I enforce this for all
> networking code submissions.

I see.  Thanks for clarifying that.

-- 
~Randy

Thread

[PATCH] Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile mohamedalrshah <mohamed.a.alrshah@ieee.org> - 2017-08-15 15:10 +0200
  Re: [PATCH] Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile Neal Cardwell <ncardwell@google.com> - 2017-08-15 16:00 +0200
    Re: [PATCH]  Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile Randy Dunlap <rdunlap@infradead.org> - 2017-08-15 18:50 +0200
      Re: [PATCH]  Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile David Miller <davem@davemloft.net> - 2017-08-15 19:40 +0200
        Re: [PATCH]  Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile Randy Dunlap <rdunlap@infradead.org> - 2017-08-15 20:00 +0200
  Re: [PATCH] Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile Neal Cardwell <ncardwell@google.com> - 2017-08-15 16:10 +0200
  Re: [PATCH]  Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile Randy Dunlap <rdunlap@infradead.org> - 2017-08-15 19:20 +0200

csiph-web