Re: [PATCHv2 02/14] fork: allow arch-override of VMAP stack alignment

From	Catalin Marinas <catalin.marinas@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv2 02/14] fork: allow arch-override of VMAP stack alignment
Date	2017-08-15 19:10 +0200
Message-ID	<ueNvP-443-13@gated-at.bofh.it> (permalink)
References	(1 earlier) <ueJBV-1pV-43@gated-at.bofh.it> <ueMJt-3xd-25@gated-at.bofh.it> <ueN2N-3DK-15@gated-at.bofh.it> <ueN2N-3DK-13@gated-at.bofh.it> <ueNcu-3Ii-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 15, 2017 at 05:39:55PM +0100, Mark Rutland wrote:
> On Tue, Aug 15, 2017 at 09:33:18AM -0700, Andy Lutomirski wrote:
> > On Tue, Aug 15, 2017 at 9:30 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> > > On Tue, Aug 15, 2017 at 09:09:36AM -0700, Andy Lutomirski wrote:
> 
> > >> This looks okay, but it might make sense to move that to a header file
> > >> so THREAD_ALIGN is always available.
> > >
> > > I was a little worried about breaking things, since arches don't define
> > > THREAD_SIZE in a consistent location.
> > >
> > > Looking again, it looks like those are all transitiviely included into
> > > each arch's <asm/thread_info.h>, so I think I can move this into
> > > <linux/thread_info.h>, which'll have to be added to kernel.fork.c's
> > > includes.
> > >
> > > Are you happy with the below fixup?
> > 
> > LGTM.
> 
> Cool. I've folded that in and pushed the updated branch.

I pulled the branch for 4.14. Thanks.

-- 
Catalin

Thread

[PATCHv2 00/14] arm64: VMAP_STACK support Mark Rutland <mark.rutland@arm.com> - 2017-08-15 15:00 +0200
  [PATCHv2 14/14] arm64: add VMAP_STACK overflow detection Mark Rutland <mark.rutland@arm.com> - 2017-08-15 15:00 +0200
  [PATCHv2 12/14] arm64: add basic VMAP_STACK support Mark Rutland <mark.rutland@arm.com> - 2017-08-15 15:00 +0200
  [PATCHv2 02/14] fork: allow arch-override of VMAP stack alignment Mark Rutland <mark.rutland@arm.com> - 2017-08-15 15:00 +0200
    Re: [PATCHv2 02/14] fork: allow arch-override of VMAP stack alignment Andy Lutomirski <luto@amacapital.net> - 2017-08-15 18:20 +0200
      Re: [PATCHv2 02/14] fork: allow arch-override of VMAP stack alignment Andy Lutomirski <luto@amacapital.net> - 2017-08-15 18:40 +0200
        Re: [PATCHv2 02/14] fork: allow arch-override of VMAP stack alignment Mark Rutland <mark.rutland@arm.com> - 2017-08-15 18:50 +0200
          Re: [PATCHv2 02/14] fork: allow arch-override of VMAP stack alignment Catalin Marinas <catalin.marinas@arm.com> - 2017-08-15 19:10 +0200
      Re: [PATCHv2 02/14] fork: allow arch-override of VMAP stack alignment Mark Rutland <mark.rutland@arm.com> - 2017-08-15 18:40 +0200
  Re: [PATCHv2 00/14] arm64: VMAP_STACK support Will Deacon <will.deacon@arm.com> - 2017-08-15 16:10 +0200
  Re: [PATCHv2 00/14] arm64: VMAP_STACK support Laura Abbott <labbott@redhat.com> - 2017-08-15 19:20 +0200
    Re: [PATCHv2 00/14] arm64: VMAP_STACK support Catalin Marinas <catalin.marinas@arm.com> - 2017-08-15 19:50 +0200
      Re: [PATCHv2 00/14] arm64: VMAP_STACK support Kees Cook <keescook@chromium.org> - 2017-08-15 20:20 +0200
    Re: [PATCHv2 00/14] arm64: VMAP_STACK support Mark Rutland <mark.rutland@arm.com> - 2017-08-15 19:50 +0200

csiph-web