Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1712307

Re: [PATCH] signal: don't remove SIGNAL_UNKILLABLE for traced tasks.

From Oleg Nesterov <oleg@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] signal: don't remove SIGNAL_UNKILLABLE for traced tasks.
Date 2017-08-15 18:20 +0200
Message-ID <ueMJs-3xd-21@gated-at.bofh.it> (permalink)
References <ueIcN-DE-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 08/15, Jamie Iles wrote:
>
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -1194,7 +1194,11 @@ force_sig_info(int sig, struct siginfo *info, struct task_struct *t)
>  			recalc_sigpending_and_wake(t);
>  		}
>  	}
> -	if (action->sa.sa_handler == SIG_DFL)
> +	/*
> +	 * Don't clear SIGNAL_UNKILLABLE for traced tasks, users won't expect
> +	 * debugging to leave init killable.
> +	 */
> +	if (action->sa.sa_handler == SIG_DFL && !t->ptrace)
>  		t->signal->flags &= ~SIGNAL_UNKILLABLE;
>  	ret = specific_send_sig_info(sig, info, t);
>  	spin_unlock_irqrestore(&t->sighand->siglock, flags);

Acked-by: Oleg Nesterov <oleg@redhat.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH] signal: don't remove SIGNAL_UNKILLABLE for traced tasks. Jamie Iles <jamie.iles@oracle.com> - 2017-08-15 13:30 +0200
  Re: [PATCH] signal: don't remove SIGNAL_UNKILLABLE for traced tasks. Oleg Nesterov <oleg@redhat.com> - 2017-08-15 18:20 +0200

csiph-web