Re: [PATCH] printk: Clean up do_syslog() error handling

From	Petr Mladek <pmladek@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] printk: Clean up do_syslog() error handling
Date	2017-08-15 17:10 +0200
Message-ID	<ueLDI-2TR-1@gated-at.bofh.it> (permalink)
References	<u8Nfc-3kJ-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat 2017-07-29 20:36:36, Nikitas Angelinas wrote:
> The error variable in do_syslog() is preemptively set to the error code
> before the error condition is checked, and then set to 0 if the error
> condition is not encountered. This is not necessary, as it is likely
> simpler to return immediately upon encountering the error condition. A
> redundant set of the error variable to 0 is also removed.
> 
> This patch has been build-tested on x86_64, but not tested for
> functionality.
> 
> Signed-off-by: Nikitas Angelinas <nikitas.angelinas@gmail.com>

The code looks better. Also the patch looks correct.

Acked-by: Petr Mladek <pmladek@suse.com>

I have pushed it into for-4.14 branch.

Best Regards,
Petr

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] printk: Clean up do_syslog() error handling Petr Mladek <pmladek@suse.com> - 2017-08-15 17:10 +0200

csiph-web