Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1712124

Re: [PATCH 01/12] genirq: Restrict effective affinity to single-target interrupts

Show all headers | View raw

On Tue, 15 Aug 2017, Marc Zyngier wrote:

> Just because CONFIG_GENERIC_IRQ_EFFECTIVE_AFF_MASK is selected
> doesn't mean that all the interrupts are using the effective
> affinity mask. For a number of them, this mask is likely to
> be empty.
> 
> In order to deal with this, let's restrict the use of the
> effective affinity mask to these interrupts that have been
> configured as "single target".

That's actually wrong. On X86 we have other restrictions, i.e. groups of
CPUs which are a subset of the affinity mask.

The point of the effective mask is to see to which CPU(s) a particular
interrupt is effectively routed. This is always a subset of the affinity
mask which is either the boot default or set by the admin.

So what you really want is to check whether the effective mask is
empty. That's an indicator that the underlying irq chip does not update the
effective mask.

The single target bit is an optimization for the hotplug case. If its set,
then we can avoid to reconfigure the affinity for that interrupt because it
either would not change or pointlessly be redirected to another single CPU
in the valid set.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/12] genirq/irqchip: Effective affinity fixups Marc Zyngier <marc.zyngier@arm.com> - 2017-08-15 13:40 +0200
  [PATCH 02/12] genirq/proc: Use the the accessor to report the effective affinity Marc Zyngier <marc.zyngier@arm.com> - 2017-08-15 13:40 +0200
  [PATCH 01/12] genirq: Restrict effective affinity to single-target interrupts Marc Zyngier <marc.zyngier@arm.com> - 2017-08-15 13:40 +0200
    Re: [PATCH 01/12] genirq: Restrict effective affinity to single-target  interrupts Thomas Gleixner <tglx@linutronix.de> - 2017-08-15 14:10 +0200
      Re: [PATCH 01/12] genirq: Restrict effective affinity to  single-target interrupts Marc Zyngier <marc.zyngier@arm.com> - 2017-08-15 14:20 +0200
  [PATCH 11/12] irqchip/mips-gic: Report that effective affinity is a single target Marc Zyngier <marc.zyngier@arm.com> - 2017-08-15 13:40 +0200
    Re: [PATCH 11/12] irqchip/mips-gic: Report that effective affinity is a single target Paul Burton <paul.burton@imgtec.com> - 2017-08-15 18:30 +0200
      Re: [PATCH 11/12] irqchip/mips-gic: Report that effective affinity is a single target Paul Burton <paul.burton@imgtec.com> - 2017-08-15 18:50 +0200
      Re: [PATCH 11/12] irqchip/mips-gic: Report that effective affinity is  a single target Marc Zyngier <marc.zyngier@arm.com> - 2017-08-15 18:50 +0200
  [PATCH 08/12] irqchip/bcm-7038-l1: Report that effective affinity is a single target Marc Zyngier <marc.zyngier@arm.com> - 2017-08-15 13:40 +0200
  [PATCH 04/12] irqchip/gic-v3: Report that effective affinity is a single target Marc Zyngier <marc.zyngier@arm.com> - 2017-08-15 13:40 +0200
  [PATCH 12/12] irqchip/xtensa-mx: Report that effective affinity is a single target Marc Zyngier <marc.zyngier@arm.com> - 2017-08-15 13:40 +0200
  [PATCH 07/12] irqchip/bcm-6345-l1: Report that effective affinity is a single target Marc Zyngier <marc.zyngier@arm.com> - 2017-08-15 13:40 +0200
  [PATCH 03/12] irqchip/gic: Report that effective affinity is a single target Marc Zyngier <marc.zyngier@arm.com> - 2017-08-15 13:40 +0200

csiph-web