Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1712083
| From | Cornelia Huck <cohuck@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFT 13/13] s390: virtio: constify ccw_device_id |
| Date | 2017-08-15 13:20 +0200 |
| Message-ID | <ueI38-An-17@gated-at.bofh.it> (permalink) |
| References | <ueHqp-8q-3@gated-at.bofh.it> <ueHqq-8q-25@gated-at.bofh.it> |
| Organization | Red Hat GmbH |
On Tue, 15 Aug 2017 16:05:44 +0530
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> ccw_device_id are not supposed to change at runtime. All functions
> working with ccw_device_id provided by <asm/ccwdev.h> work with
> const ccw_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/s390/virtio/virtio_ccw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c
> index b18fe20..b43dbba 100644
> --- a/drivers/s390/virtio/virtio_ccw.c
> +++ b/drivers/s390/virtio/virtio_ccw.c
> @@ -1307,7 +1307,7 @@ static int virtio_ccw_cio_notify(struct ccw_device *cdev, int event)
> return rc;
> }
>
> -static struct ccw_device_id virtio_ids[] = {
> +static const struct ccw_device_id virtio_ids[] = {
> { CCW_DEVICE(0x3832, 0) },
> {},
> };
Acked-by: Cornelia Huck <cohuck@redhat.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFT 00/13] constify s390 ccw_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-15 12:40 +0200
[RFT 04/13] s390: con3215: constify ccw_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-15 12:40 +0200
[RFT 08/13] s390: vmur: constify ccw_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-15 12:40 +0200
[RFT 09/13] s390: ctcm: constify ccw_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-15 12:40 +0200
[RFT 12/13] s390: zfcp: constify ccw_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-15 12:40 +0200
[RFT 03/13] s390: dasd_fba: constify ccw_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-15 12:40 +0200
[RFT 13/13] s390: virtio: constify ccw_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-15 12:40 +0200
Re: [RFT 13/13] s390: virtio: constify ccw_device_id Cornelia Huck <cohuck@redhat.com> - 2017-08-15 13:20 +0200
[RFT 02/13] s390: dasd_eckd: constify ccw_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-15 12:40 +0200
[RFT 01/13] s390: ccwdev: constify ccw_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-15 12:40 +0200
[RFT 07/13] s390: tape_3590: constify ccw_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-15 12:40 +0200
Re: [RFT 00/13] constify s390 ccw_device_id Heiko Carstens <heiko.carstens@de.ibm.com> - 2017-08-15 13:40 +0200
csiph-web