Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1712063

RE: [PATCH] New Chapter on CodingStyle .

Show all headers | View raw

From: Jonathan Corbet
> Sent: 12 August 2017 15:55
...
> > +		Chapter 20: Put values on initialisers without exception
> > +
> > +When declaring variables on functions must put values:
> 
> Thanks for sending a patch for the kernel's documentation.
> Unfortunately, I can't accept this patch for a couple of reasons:
...
> - The coding style document is there to describe the community's
>   standards for kernel code.  It is *not* a mechanism for imposing new
>   standards.  If you really think that the kernel community should adopt
>   this rule, you will need to argue for it on the mailing lists.  I will
>   say, though, that I do not expect that this effort would be successful.

I'd even go as far as suggesting almost the opposite.
Declarations should only have initialisers if the value is constant.

	David

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH]  New Chapter on CodingStyle . Jonathan Corbet <corbet@lwn.net> - 2017-08-12 17:00 +0200
  RE: [PATCH]  New Chapter on CodingStyle . David Laight <David.Laight@ACULAB.COM> - 2017-08-15 12:50 +0200
    Re: [PATCH]  New Chapter on CodingStyle . Stephen Hemminger <stephen@networkplumber.org> - 2017-08-15 18:30 +0200
      RE: [PATCH]  New Chapter on CodingStyle . David Laight <David.Laight@ACULAB.COM> - 2017-08-15 19:00 +0200

csiph-web