Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1711956

[PATCH 3/3] ALSA: firewire-motu: constify snd_rawmidi_ops structures

From Julia Lawall <Julia.Lawall@lip6.fr>
Newsgroups linux.kernel
Subject [PATCH 3/3] ALSA: firewire-motu: constify snd_rawmidi_ops structures
Date 2017-08-15 10:40 +0200
Message-ID <ueFyi-7nU-7@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


These snd_rawmidi_ops structures are only passed as the third
argument of snd_rawmidi_set_ops.  This argument is const, so the
snd_rawmidi_ops structures can be const too.

Done with the help of Coccinelle.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 sound/firewire/motu/motu-midi.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/firewire/motu/motu-midi.c b/sound/firewire/motu/motu-midi.c
index e3acfcc..e55cab6 100644
--- a/sound/firewire/motu/motu-midi.c
+++ b/sound/firewire/motu/motu-midi.c
@@ -128,12 +128,12 @@ static void set_midi_substream_names(struct snd_motu *motu,
 
 int snd_motu_create_midi_devices(struct snd_motu *motu)
 {
-	static struct snd_rawmidi_ops capture_ops = {
+	static const struct snd_rawmidi_ops capture_ops = {
 		.open		= midi_capture_open,
 		.close		= midi_capture_close,
 		.trigger	= midi_capture_trigger,
 	};
-	static struct snd_rawmidi_ops playback_ops = {
+	static const struct snd_rawmidi_ops playback_ops = {
 		.open		= midi_playback_open,
 		.close		= midi_playback_close,
 		.trigger	= midi_playback_trigger,

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH 3/3] ALSA: firewire-motu: constify snd_rawmidi_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-08-15 10:40 +0200
  Re: [PATCH 3/3] ALSA: firewire-motu: constify snd_rawmidi_ops  structures Takashi Sakamoto <o-takashi@sakamocchi.jp> - 2017-08-15 11:00 +0200
  Re: [PATCH 3/3] ALSA: firewire-motu: constify snd_rawmidi_ops structures Takashi Iwai <tiwai@suse.de> - 2017-08-15 11:00 +0200
    Re: [PATCH 3/3] ALSA: firewire-motu: constify snd_rawmidi_ops  structures Julia Lawall <julia.lawall@lip6.fr> - 2017-08-15 11:10 +0200
      Re: [PATCH 3/3] ALSA: firewire-motu: constify snd_rawmidi_ops structures Takashi Iwai <tiwai@suse.de> - 2017-08-15 11:30 +0200
  Re: [PATCH 3/3] ALSA: firewire-motu: constify snd_rawmidi_ops structures Takashi Iwai <tiwai@suse.de> - 2017-08-15 14:10 +0200

csiph-web