Groups > linux.kernel > #1711903

Re: [PATCH v4 2/4] thermal: add brcmstb AVS TMON driver

From	Zhang Rui <rui.zhang@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 2/4] thermal: add brcmstb AVS TMON driver
Date	2017-08-15 08:50 +0200
Message-ID	<ueDPR-6jk-37@gated-at.bofh.it> (permalink)
References	<ucHkS-4V7-25@gated-at.bofh.it> <ucHkS-4V7-23@gated-at.bofh.it> <ueDd7-64p-3@gated-at.bofh.it> <ueDPQ-6jk-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2017-08-15 at 08:42 +0200, Rafał Miłecki wrote:
> On 2017-08-15 08:08, Zhang Rui wrote:
> > 
> > > 
> > > diff --git a/drivers/thermal/broadcom/Kconfig
> > > b/drivers/thermal/broadcom/Kconfig
> > > index 42c098e..c106a15 100644
> > > --- a/drivers/thermal/broadcom/Kconfig
> > > +++ b/drivers/thermal/broadcom/Kconfig
> > > @@ -6,6 +6,13 @@ config BCM2835_THERMAL
> > >  	help
> > >  	  Support for thermal sensors on Broadcom bcm2835 SoCs.
> > >  
> > > +config BRCMSTB_THERMAL
> > > +	tristate "Broadcom STB AVS TMON thermal driver"
> > > +	depends on ARCH_BRCMSTB || COMPILE_TEST
> > > +	help
> > > +	  Enable this driver if you have a Broadcom STB SoC and
> > > would like
> > > +	  thermal framework support.
> > > +
> > I don't understand why I got the following checkpatch warning
> > 
> > WARNING: please write a paragraph that describes the config symbol
> > fully
> > #73: FILE: drivers/thermal/broadcom/Kconfig:9:
> > +config BRCMSTB_THERMAL
> > 
> > I didn't see this for other Kconfig changes.
> It's because your help message is only 2 lines long (instead of 3).
> 
> Some (many?) maintainers aren't pedantic about that, a common sense 
> should
> be applied ;)

thanks for explaining.
Patch 1 and 2 queued for next merge window.

-rui

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 2/4] thermal: add brcmstb AVS TMON driver Zhang Rui <rui.zhang@intel.com> - 2017-08-15 08:10 +0200
  Re: [PATCH v4 2/4] thermal: add brcmstb AVS TMON driver Rafał Miłecki <rafal@milecki.pl> - 2017-08-15 08:50 +0200
    Re: [PATCH v4 2/4] thermal: add brcmstb AVS TMON driver Zhang Rui <rui.zhang@intel.com> - 2017-08-15 08:50 +0200

csiph-web