[PATCH 1/3] thunderbolt: Remove superfluous check

From	"Bernat, Yehezkel" <yehezkel.bernat@intel.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/3] thunderbolt: Remove superfluous check
Date	2017-08-15 07:20 +0200
Message-ID	<ueCqJ-5xr-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The key size is tested by hex2bin() already (as '\0' isn't an hex digit)

Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Yehezkel Bernat <yehezkel.bernat@intel.com>
---
 drivers/thunderbolt/switch.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c
index e9391bb..69fde0b 100644
--- a/drivers/thunderbolt/switch.c
+++ b/drivers/thunderbolt/switch.c
@@ -808,9 +808,6 @@ static ssize_t key_store(struct device *dev, struct device_attribute *attr,
 	u8 key[TB_SWITCH_KEY_SIZE];
 	ssize_t ret = count;
 
-	if (count < 64)
-		return -EINVAL;
-
 	if (hex2bin(key, buf, sizeof(key)))
 		return -EINVAL;
 
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] thunderbolt: Remove superfluous check "Bernat, Yehezkel" <yehezkel.bernat@intel.com> - 2017-08-15 07:20 +0200
  Re: [PATCH 1/3] thunderbolt: Remove superfluous check Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-08-15 09:10 +0200
  Re: [PATCH 1/3] thunderbolt: Remove superfluous check Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-08-15 11:40 +0200

csiph-web