Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1710546

qustion about eeh_add_virt_device

Show all headers | View raw

Hello,

At the suggestion of Christoph Hellwig, I am working on inlining the
functions stored in the err_handler field of a pci_driver structure into
the pci_driver structure itself.  A number of functions in the file
arch/powerpc/kernel/eeh_driver.c have code like:

        if (!driver->err_handler ||
            !driver->err_handler->error_detected) {
                eeh_pcid_put(dev);
                return NULL;
        }

This I would just convert to:

        if (!driver->error_detected) {
                eeh_pcid_put(dev);
                return NULL;
        }

But I am not sure what is best to do about eeh_add_virt_device, which
contains:

                if (driver->err_handler)
		        return NULL;

Should I try to find a subfield of the err_handler that is guaranteed to
be there if anything is there?  Or could the test just be dropped, leaving
a direct return NULL?

thanks,
julia

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

qustion about eeh_add_virt_device Julia Lawall <julia.lawall@lip6.fr> - 2017-08-13 17:00 +0200
  Re: qustion about eeh_add_virt_device Russell Currey <ruscur@russell.cc> - 2017-08-22 07:50 +0200

csiph-web