Re: [PATCH 1/3] [media] usb: constify usb_device_id

From	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] [media] usb: constify usb_device_id
Date	2017-08-13 14:30 +0200
Message-ID	<ue0bM-78T-7@gated-at.bofh.it> (permalink)
References	<udWUx-4XK-3@gated-at.bofh.it> <udWUx-4XK-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Arvind,

Thank you for the patch.

On Sunday 13 Aug 2017 14:24:43 Arvind Yadav wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
> 
> 'drivers/media/usb/b2c2/flexcop-usb.c' Fix checkpatch.pl error:
> ERROR: space prohibited before open square bracket '['.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/media/usb/airspy/airspy.c                 | 2 +-
>  drivers/media/usb/as102/as102_usb_drv.c           | 2 +-
>  drivers/media/usb/b2c2/flexcop-usb.c              | 2 +-
>  drivers/media/usb/cpia2/cpia2_usb.c               | 2 +-
>  drivers/media/usb/dvb-usb-v2/az6007.c             | 2 +-
>  drivers/media/usb/hackrf/hackrf.c                 | 2 +-
>  drivers/media/usb/hdpvr/hdpvr-core.c              | 2 +-
>  drivers/media/usb/msi2500/msi2500.c               | 2 +-
>  drivers/media/usb/s2255/s2255drv.c                | 2 +-
>  drivers/media/usb/stk1160/stk1160-core.c          | 2 +-
>  drivers/media/usb/stkwebcam/stk-webcam.c          | 2 +-
>  drivers/media/usb/tm6000/tm6000-cards.c           | 2 +-
>  drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c | 2 +-
>  drivers/media/usb/ttusb-dec/ttusb_dec.c           | 2 +-
>  drivers/media/usb/usbtv/usbtv-core.c              | 2 +-
>  drivers/media/usb/uvc/uvc_driver.c                | 2 +-

For the UVC driver,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  drivers/media/usb/zr364xx/zr364xx.c               | 2 +-
>  17 files changed, 17 insertions(+), 17 deletions(-)

-- 
Regards,

Laurent Pinchart

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] [media] usb: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-13 11:00 +0200
  Re: [PATCH 1/3] [media] usb: constify usb_device_id Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-08-13 14:30 +0200

csiph-web