Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1710195
| From | Pali Rohár <pali.rohar@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 3/4] platform/x86: peaq-wmi: Evaluate wmi method with instance number 0x0 |
| Date | 2017-08-12 09:50 +0200 |
| Message-ID | <udzlf-69b-9@gated-at.bofh.it> (permalink) |
| References | <udzlf-69b-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
According to Hans de Goede, WMI interface of thh peaq-wmi module has 10
instances but corresponding ACPI WMBC method does not check Arg0 (instance
number) at all. Therefore evaluate WMI method with first instance number
(0x0) instead of second (0x1).
Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>
---
drivers/platform/x86/peaq-wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/peaq-wmi.c b/drivers/platform/x86/peaq-wmi.c
index 77d1f90..f59a5a2 100644
--- a/drivers/platform/x86/peaq-wmi.c
+++ b/drivers/platform/x86/peaq-wmi.c
@@ -39,7 +39,7 @@ static void peaq_wmi_poll(struct input_polled_dev *dev)
struct acpi_buffer input = { sizeof(dummy), &dummy };
struct acpi_buffer output = { sizeof(obj), &obj };
- status = wmi_evaluate_method(PEAQ_DOLBY_BUTTON_GUID, 1,
+ status = wmi_evaluate_method(PEAQ_DOLBY_BUTTON_GUID, 0,
PEAQ_DOLBY_BUTTON_METHOD_ID,
&input, &output);
if (ACPI_FAILURE(status))
--
1.7.9.5
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] platform/x86: Fix check for method instance number Pali Rohár <pali.rohar@gmail.com> - 2017-08-12 09:50 +0200
[PATCH 3/4] platform/x86: peaq-wmi: Evaluate wmi method with instance number 0x0 Pali Rohár <pali.rohar@gmail.com> - 2017-08-12 09:50 +0200
Re: [PATCH 3/4] platform/x86: peaq-wmi: Evaluate wmi method with instance number 0x0 Hans de Goede <hdegoede@redhat.com> - 2017-08-12 22:20 +0200
[PATCH 2/4] platform/x86: asus-wmi: Evaluate wmi method with instance number 0x0 Pali Rohár <pali.rohar@gmail.com> - 2017-08-12 09:50 +0200
[PATCH 1/4] platform/x86: mxm-wmi: Evaluate wmi method with instance number 0x0 Pali Rohár <pali.rohar@gmail.com> - 2017-08-12 09:50 +0200
Re: [PATCH 0/4] platform/x86: Fix check for method instance number Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-08-13 15:00 +0200
Re: [PATCH 0/4] platform/x86: Fix check for method instance number Darren Hart <dvhart@infradead.org> - 2017-08-17 17:30 +0200
Re: [PATCH 0/4] platform/x86: Fix check for method instance number Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-08-17 19:40 +0200
csiph-web