Re: [PATCH v6 1/6] clk: sunxi-ng: div: Add support for fixed post-divider

From	icenowy@aosc.io
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 1/6] clk: sunxi-ng: div: Add support for fixed post-divider
Date	2017-08-12 05:10 +0200
Message-ID	<uduYh-3CJ-5@gated-at.bofh.it> (permalink)
References	<u3aet-4Pd-3@gated-at.bofh.it> <u3aet-4Pd-1@gated-at.bofh.it> <u4a2K-2Ji-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

在 2017-07-17 16:52，Maxime Ripard 写道：
> On Fri, Jul 14, 2017 at 05:49:23PM +0300, Priit Laes wrote:
>> SATA clock on sun4i/sun7i is of type (parent) / M / 6 where
>> 6 is fixed post-divider.
>> 
>> Signed-off-by: Priit Laes <plaes@plaes.org>
>> ---
>>  drivers/clk/sunxi-ng/ccu_div.c | 15 +++++++++++++--
>>  drivers/clk/sunxi-ng/ccu_div.h |  3 ++-
>>  2 files changed, 15 insertions(+), 3 deletions(-)
>> 
>> diff --git a/drivers/clk/sunxi-ng/ccu_div.c 
>> b/drivers/clk/sunxi-ng/ccu_div.c
>> index c0e5c10..744502a 100644
>> --- a/drivers/clk/sunxi-ng/ccu_div.c
>> +++ b/drivers/clk/sunxi-ng/ccu_div.c
>> @@ -21,6 +21,9 @@ static unsigned long ccu_div_round_rate(struct 
>> ccu_mux_internal *mux,
>>  {
>>  	struct ccu_div *cd = data;
>> 
>> +	if (cd->common.features & CCU_FEATURE_FIXED_POSTDIV)
>> +		rate *= cd->fixed_post_div;
>> +
>>  	return divider_round_rate_parent(&cd->common.hw, parent,
>>  					 rate, parent_rate,
>>  					 cd->div.table, cd->div.width,
> 
> 
> You still haven't addressed the biggest issue with this patch, see:
> https://patchwork.kernel.org/patch/9825565/

I think he has already did the changes suggested in the review.

(P.S. during developing R40 CCU driver I found that pll-periph0-sata
also needs this patch, so I'm rechecking it)

> 
> Maxime
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v6 1/6] clk: sunxi-ng: div: Add support for fixed  post-divider icenowy@aosc.io - 2017-08-12 05:10 +0200
  Re: [linux-sunxi] Re: [PATCH v6 1/6] clk: sunxi-ng: div: Add support  for fixed post-divider Chen-Yu Tsai <wens@csie.org> - 2017-08-12 06:20 +0200
    Re: [linux-sunxi] Re: [PATCH v6 1/6] clk: sunxi-ng: div: Add support  for fixed post-divider icenowy@aosc.io - 2017-08-12 07:00 +0200

csiph-web