Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1710024

Re: [PATCH 1/4] i2c: davinci: Preserve return value of devm_clk_get

Show all headers | View raw

On 08/02/2017 05:17 PM, Franklin S Cooper Jr wrote:
> The i2c driver can run into driver dependency issues if its loaded
> before a clock driver it depends on. Therefore, EPROBE_DEFER may be
> returned by devm_clk_get and should be returned in probe to allow the
> kernel to reprobe the driver at a later time. This patch allows the error
> value returned by devm_clk_get to be passed through and not overwritten.
> 
> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>

I think it's better to drop internal tags.

Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

> ---
>   drivers/i2c/busses/i2c-davinci.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
> index 9e7ef5c..5749aac 100644
> --- a/drivers/i2c/busses/i2c-davinci.c
> +++ b/drivers/i2c/busses/i2c-davinci.c
> @@ -801,7 +801,7 @@ static int davinci_i2c_probe(struct platform_device *pdev)
>   
>   	dev->clk = devm_clk_get(&pdev->dev, NULL);
>   	if (IS_ERR(dev->clk))
> -		return -ENODEV;
> +		return PTR_ERR(dev->clk);
>   	clk_prepare_enable(dev->clk);
>   
>   	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> 

-- 
regards,
-grygorii

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] ARM: dts: keystone-k2g: Add I2C support for 66AK2G Franklin S Cooper Jr <fcooper@ti.com> - 2017-08-03 00:20 +0200
  [PATCH 1/4] i2c: davinci: Preserve return value of devm_clk_get Franklin S Cooper Jr <fcooper@ti.com> - 2017-08-03 00:20 +0200
    Re: [PATCH 1/4] i2c: davinci: Preserve return value of devm_clk_get Grygorii Strashko <grygorii.strashko@ti.com> - 2017-08-12 00:10 +0200
  [PATCH 4/4] ARM: dts: keystone-k2g: Add I2C nodes Franklin S Cooper Jr <fcooper@ti.com> - 2017-08-03 00:20 +0200
    Re: [PATCH 4/4] ARM: dts: keystone-k2g: Add I2C nodes Grygorii Strashko <grygorii.strashko@ti.com> - 2017-08-12 00:20 +0200
  [PATCH 3/4] dt-bindings: i2c: i2c-davinci: Update binding for 66AK2Gx pwr dm property Franklin S Cooper Jr <fcooper@ti.com> - 2017-08-03 00:30 +0200
    Re: [PATCH 3/4] dt-bindings: i2c: i2c-davinci: Update binding for  66AK2Gx pwr dm property Rob Herring <robh@kernel.org> - 2017-08-10 18:40 +0200

csiph-web