Re: [PATCH v3] net: stmmac: Use the right logging function in stmmac_mdio_register

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] net: stmmac: Use the right logging function in stmmac_mdio_register
Date	Fri, 11 Aug 2017 23:40:02 +0200
Message-ID	<udpOW-eI-19@gated-at.bofh.it> (permalink)
References	<ucX6h-723-1@gated-at.bofh.it>
X-Mailer	Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)
MIME-Version	1.0
Content-Type	Text/Plain; charset=us-ascii
Content-Transfer-Encoding	7bit
X-Greylist	Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 11 Aug 2017 14:39:12 -0700 (PDT)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	21
Organization	linux.* mail to news gateway
X-Original-Cc	peppe.cavallaro@st.com, alexandre.torgue@st.com, andrew@lunn.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Fri, 11 Aug 2017 14:39:11 -0700 (PDT)
X-Original-Message-ID	<20170811.143911.1295975110250079627.davem@davemloft.net>
X-Original-References	<20170810145605.27048-1-romain.perier@collabora.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1709981

Show key headers only | View raw

From: Romain Perier <romain.perier@collabora.com>
Date: Thu, 10 Aug 2017 16:56:05 +0200

> Currently, the function stmmac_mdio_register() is only used by
> stmmac_dvr_probe() from stmmac_main.c, in order to register the MDIO bus
> and probe information about the PHY. As this function is called before
> calling register_netdev(), all messages logged from stmmac_mdio_register
> are prefixed by "(unnamed net_device)". The goal of netdev_info or
> netdev_err is to dump useful infos about a net_device, when this data
> structure is partially initialized, there is no point for using these
> functions.
> 
> This commit fixes the issue by replacing all netdev_*() by the
> corresponding dev_*() function for logging. The last netdev_info is
> replaced by phy_attached_info(), as a valid phydev can be used at this
> point.
> 
> Signed-off-by: Romain Perier <romain.perier@collabora.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] net: stmmac: Use the right logging function in stmmac_mdio_register Romain Perier <romain.perier@collabora.com> - 2017-08-10 17:00 +0200
  Re: [PATCH v3] net: stmmac: Use the right logging function in  stmmac_mdio_register David Miller <davem@davemloft.net> - 2017-08-11 23:40 +0200

csiph-web