Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1709918

Re: [PATCH v5 06/12] mfd: wm97xx-core: core support for wm97xx Codec

Show all headers | View raw

Lee Jones <lee.jones@linaro.org> writes:

> On Sun, 06 Aug 2017, Robert Jarzmik wrote:

Hi Lee,

I basically agree with all your comments, so I will only answer to your
questions.
>> +#include <linux/module.h>
>
> Why separate this?
No point, for v6.
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>
> Can you use the short version?
Yeah, sure.

>> +#ifndef __LINUX_MFD_WM97XX_H
>> +#define __LINUX_MFD_WM97XX_H
>> +
>> +struct regmap;
>> +struct wm97xx_batt_pdata;
>> +struct snd_ac97;
>
> What are you using these for?
There are for the structure just below, which doesn't need the implementation
details of these structures, but does need the definition to properly compile.

>> +struct wm97xx_platform_data {
>> +	struct snd_ac97 *ac97;
>> +	struct regmap *regmap;
>> +	struct wm97xx_batt_pdata *batt_pdata;
>> +};
This is the structure "just below" I'm speaking of.

Thanks for the review.

-- 
Robert

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 00/12] AC97 device/driver model revamp Robert Jarzmik <robert.jarzmik@free.fr> - 2017-08-06 23:40 +0200
  [PATCH v5 07/12] Input: wm97xx: add new AC97 bus support Robert Jarzmik <robert.jarzmik@free.fr> - 2017-08-06 23:40 +0200
  [PATCH v5 02/12] ALSA: ac97: add an ac97 bus Robert Jarzmik <robert.jarzmik@free.fr> - 2017-08-06 23:40 +0200
  [PATCH v5 08/12] ASoC: wm9713: add ac97 new bus support Robert Jarzmik <robert.jarzmik@free.fr> - 2017-08-06 23:40 +0200
  [PATCH v5 11/12] ASoC: wm9705: add ac97 new bus support Robert Jarzmik <robert.jarzmik@free.fr> - 2017-08-06 23:40 +0200
  [PATCH v5 03/12] ASoC: add new ac97 bus support Robert Jarzmik <robert.jarzmik@free.fr> - 2017-08-06 23:40 +0200
  [PATCH v5 01/12] ALSA: ac97: split out the generic ac97 registers Robert Jarzmik <robert.jarzmik@free.fr> - 2017-08-06 23:40 +0200
  [PATCH v5 05/12] Input: wm97xx: split out touchscreen registering Robert Jarzmik <robert.jarzmik@free.fr> - 2017-08-06 23:40 +0200
  [PATCH v5 06/12] mfd: wm97xx-core: core support for wm97xx Codec Robert Jarzmik <robert.jarzmik@free.fr> - 2017-08-06 23:40 +0200
    Re: [PATCH v5 06/12] mfd: wm97xx-core: core support for wm97xx Codec Lee Jones <lee.jones@linaro.org> - 2017-08-08 13:10 +0200
      Re: [PATCH v5 06/12] mfd: wm97xx-core: core support for wm97xx Codec Robert Jarzmik <robert.jarzmik@free.fr> - 2017-08-11 21:10 +0200
  [PATCH v5 09/12] ASoC: wm9712: add ac97 new bus support Robert Jarzmik <robert.jarzmik@free.fr> - 2017-08-06 23:40 +0200
  [PATCH v5 12/12] ASoC: pxa: switch to new ac97 bus support Robert Jarzmik <robert.jarzmik@free.fr> - 2017-08-06 23:40 +0200
  Re: [PATCH v5 00/12] AC97 device/driver model revamp Robert Jarzmik <robert.jarzmik@free.fr> - 2017-08-23 21:40 +0200

csiph-web