Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1709913

Re: [PATCH 3/3] iommu: prevent VMD child devices from being remapping targets

Show all headers | View raw

Hi Robin, thanks for the reply.

On 08/11/2017 12:25 PM, Robin Murphy wrote:
> On 07/08/17 20:57, Jon Derrick wrote:
>> VMD child devices must use the VMD endpoint's ID as the DMA source.
>> Because of this, there needs to be a way to link the parent VMD
>> endpoint's DMAR domain to the VMD child devices' DMAR domain such that
>> attaching and detaching child devices modify the endpoint's DMAR mapping
>> and prevents early detaching.
> > That sounds like either pci_device_group() needs modifying, or perhaps
> that intel-iommu needs its own extended iommu_ops::device_group
> implementation, to ensure that VMD child devices get put in the same
> group as their parent - if they share requester IDs they can't feasibly
> be attached to different domains anyway.
> 
> Robin.
Yes it seems like that to me too. I have a high-level understanding of
the changes required but not too much in the nitty-gritty details. It's
a bit more complicated anyways because VMD emerges a set of root ports,
and AFAICT, PCI ACS end at the root ports and iommu groups rely on ACS
to group devices. Either way it's not within the scope of VMD.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] MAINTAINERS: Add Jonathan Derrick as VMD maintainer Jon Derrick <jonathan.derrick@intel.com> - 2017-08-07 22:00 +0200
  [PATCH 3/3] iommu: prevent VMD child devices from being remapping targets Jon Derrick <jonathan.derrick@intel.com> - 2017-08-07 22:00 +0200
    Re: [PATCH 3/3] iommu: prevent VMD child devices from being  remapping targets Bjorn Helgaas <helgaas@kernel.org> - 2017-08-11 19:20 +0200
    Re: [PATCH 3/3] iommu: prevent VMD child devices from being remapping  targets Robin Murphy <robin.murphy@arm.com> - 2017-08-11 20:30 +0200
      Re: [PATCH 3/3] iommu: prevent VMD child devices from being remapping  targets Jon Derrick <jonathan.derrick@intel.com> - 2017-08-11 20:50 +0200
  Re: [PATCH 1/3] MAINTAINERS: Add Jonathan Derrick as VMD maintainer Bjorn Helgaas <helgaas@kernel.org> - 2017-08-11 19:30 +0200
  Re: [PATCH 1/3] MAINTAINERS: Add Jonathan Derrick as VMD maintainer Keith Busch <keith.busch@intel.com> - 2017-08-11 20:20 +0200

csiph-web