Re: [PATCH] selftests: memfd: Align STACK_SIZE for ARM AArch64 system

From	Shuah Khan <shuah@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] selftests: memfd: Align STACK_SIZE for ARM AArch64 system
Date	2017-08-11 18:20 +0200
Message-ID	<udkPg-5Kw-17@gated-at.bofh.it> (permalink)
References	<ucTFo-4RQ-21@gated-at.bofh.it> <udkvU-5mU-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/11/2017 09:55 AM, Sumit Semwal wrote:
> Hello Orson,
> 
> Thanks for the patch.
> 
> On 10 August 2017 at 16:34, Orson Zhai <orson.zhai@linaro.org> wrote:
>> The stack size should be 16 bytes aligned in arm64 system. The similar
>> patch has been merged already.
>>
>>> <commit id: 1f78dda2cf5e4eeb00aee2a01c9515e2e704b4c0>
>>> selftests: memfd_test: Revised STACK_SIZE to make it 16-byte aligned
>>>
>>>    There is a mandate of 16-byte aligned stack on AArch64 [1], so the
>>>    STACK_SIZE here should also be 16-byte aligned, otherwise we would
>>>    get an error when calling clone().
>>>
>>>    [1] http://lxr.free-electrons.com/source/arch/arm64/kernel/process.c#L265
>>>
>>>    Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>
>>>    Acked-by: Arnd Bergmann <arnd@arndb.de>
>>>    Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>>
>> Signed-off-by: Orson Zhai <orson.zhai@linaro.org>
> Please feel free to add my
> Reviewed-by: Sumit Semwal <sumit.semwal@linaro.org>

Thanks for the patch and review.
Applied to linux-kselftest next for 4.14-rc1

thanks,
-- Shuah

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] selftests: memfd: Align STACK_SIZE for ARM AArch64 system Orson Zhai <orson.zhai@linaro.org> - 2017-08-10 13:20 +0200
  Re: [PATCH] selftests: memfd: Align STACK_SIZE for ARM AArch64 system Sumit Semwal <sumit.semwal@linaro.org> - 2017-08-11 18:00 +0200
    Re: [PATCH] selftests: memfd: Align STACK_SIZE for ARM AArch64 system Shuah Khan <shuah@kernel.org> - 2017-08-11 18:20 +0200

csiph-web