Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1709667

[PATCH 4/5] clocksource/drivers/Kconfig: Fix CLKSRC_PISTACHIO dependencies

From Daniel Lezcano <daniel.lezcano@linaro.org>
Newsgroups linux.kernel
Subject [PATCH 4/5] clocksource/drivers/Kconfig: Fix CLKSRC_PISTACHIO dependencies
Date 2017-08-11 16:20 +0200
Message-ID <udiX8-4AP-35@gated-at.bofh.it> (permalink)
References <udiX7-4AP-1@gated-at.bofh.it> <udiX7-4AP-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Matt Redfearn <matt.redfearn@imgtec.com>

In v4.13, CLKSRC_PISTACHIO can select TIMER_OF on architectures without
GENERIC_CLOCKEVENTS, resulting in a struct clock_event_device missing
some required features and build breakage compiling timer_of.c. One of
the symbols selecting TIMER_OF is CLKSRC_PISTACHIO, so add the
dependency on GENERIC_CLOCKEVENTS.

Thanks to kbuild test robot for finding this error
(https://lkml.org/lkml/2017/7/16/249)

Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
Suggested-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index fcae5ca..54a67f8 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -262,7 +262,7 @@ config CLKSRC_LPC32XX
 
 config CLKSRC_PISTACHIO
 	bool "Clocksource for Pistachio SoC" if COMPILE_TEST
-	depends on HAS_IOMEM
+	depends on GENERIC_CLOCKEVENTS && HAS_IOMEM
 	select TIMER_OF
 	help
 	  Enables the clocksource for the Pistachio SoC.
-- 
2.7.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

(none) Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-08-11 16:20 +0200
  Re: [GIT PULL] clockevents: fixes for 4.13-rc4 Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-08-11 16:20 +0200
    Re: [GIT PULL] clockevents: fixes for 4.13-rc4 Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-11 20:50 +0200
      Re: [GIT PULL] clockevents: fixes for 4.13-rc4 Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-08-11 23:50 +0200
        Re: [GIT PULL] clockevents: fixes for 4.13-rc4 Linus Torvalds <torvalds@linux-foundation.org> - 2017-08-12 01:00 +0200
        Re: [GIT PULL] clockevents: fixes for 4.13-rc4 Ingo Molnar <mingo@kernel.org> - 2017-08-12 01:40 +0200
  [PATCH 1/5] clocksource/drivers/arm_arch_timer: Fix mem frame loop initialization Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-08-11 16:20 +0200
    [PATCH 5/5] clocksource/drivers/arm_arch_timer: Avoid infinite recursion when ftrace is enabled Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-08-11 16:20 +0200
    [PATCH 2/5] clocksource/drivers/em_sti: Fix error return codes in em_sti_probe() Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-08-11 16:20 +0200
    [PATCH 3/5] clocksource/drivers/timer-of: Checking for IS_ERR() instead of NULL Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-08-11 16:20 +0200
    [PATCH 4/5] clocksource/drivers/Kconfig: Fix CLKSRC_PISTACHIO dependencies Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-08-11 16:20 +0200
  Re: [GIT PULL] clockevents: fixes for 4.13-rc4 Ingo Molnar <mingo@kernel.org> - 2017-08-13 11:50 +0200

csiph-web