Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1709544

Re: [PATCH 2/2] leds: lm3533: constify attribute_group structure

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu 2017-08-10 12:28:09, Amitoj Kaur Chawla wrote:
> Functions working with attribute_groups provided by <linux/device.h>
> work with const attribute_group. These attribute_group structures do not
> change at runtime so mark them as const.
> 
> File size before:
>  text      data     bss     dec     hex filename
>  8272      4608      64   12944    3290 drivers/leds/leds-lm3533.o
> 
> File size after:
>  text      data     bss     dec     hex filename
>  8368      4512      64   12944    3290 drivers/leds/leds-lm3533.o
> 
> This change was made with the help of Coccinelle.
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>

patches 1,2:

Acked-by: Pavel Machek <pavel@ucw.cz>

								Pavel

> -static struct attribute_group lm3533_led_attribute_group = {
> +static const struct attribute_group lm3533_led_attribute_group = {
>  	.is_visible	= lm3533_led_attr_is_visible,
>  	.attrs		= lm3533_led_attributes
>  };

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] leds: lm3533: constify attribute_group structure Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2017-08-10 18:30 +0200
  Re: [PATCH 2/2] leds: lm3533: constify attribute_group structure Pavel Machek <pavel@ucw.cz> - 2017-08-11 14:40 +0200
  Re: [PATCH 2/2] leds: lm3533: constify attribute_group structure Jacek Anaszewski <jacek.anaszewski@gmail.com> - 2017-08-14 22:50 +0200

csiph-web