Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1709454

Re: [PATCH 2/2] mm, oom: fix potential data corruption when oom_reaper races with writer

Show all headers | View raw

On Fri, Aug 11, 2017 at 12:22:56PM +0200, Andrea Arcangeli wrote:
> disk block? This would happen on ext4 as well if mounted with -o
> journal=data instead of -o journal=ordered in fact, perhaps you simply

Oops above I meant journal=writeback, journal=data is even stronger
than journal=ordered of course.

And I shall clarify further that old disk content can only showup
legitimately on journal=writeback after a hard reboot or crash or in
general an unclean unmount. Even if there's no journaling at all
(i.e. ext2/vfat) old disk content cannot be shown at any given time no
matter what if there's no unclean unmount that requires a journal
reply.

This theory of a completely unrelated fs bug showing you disk content
as result of the OOM reaper induced SIGBUS interrupting a
copy_from_user at its very start, is purely motivated by the fact like
Michal I didn't see much explanation on the VM side that could cause
those not-zero not-0xff values showing up in the buffer of the write
syscall. You can try to change fs and see if it happens again to rule
it out. If it always happens regardless of the filesystem used, then
it's likely not a fs bug of course. You've got an entire and aligned
4k fs block showing up that data.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] mm, oom: fix oom_reaper fallouts Michal Hocko <mhocko@kernel.org> - 2017-08-07 13:40 +0200
  [PATCH 1/2] mm: fix double mmap_sem unlock on MMF_UNSTABLE enforced SIGBUS Michal Hocko <mhocko@kernel.org> - 2017-08-07 13:40 +0200
  [PATCH 2/2] mm, oom: fix potential data corruption when oom_reaper races with writer Michal Hocko <mhocko@kernel.org> - 2017-08-07 13:40 +0200
    Re: [PATCH 2/2] mm, oom: fix potential data corruption when  oom_reaper races with writer Andrea Arcangeli <aarcange@redhat.com> - 2017-08-08 19:50 +0200
      Re: [PATCH 2/2] mm, oom: fix potential data corruption when oom_reaper races with writer Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-08-09 01:40 +0200
        Re: [PATCH 2/2] mm, oom: fix potential data corruption when  oom_reaper races with writer Andrea Arcangeli <aarcange@redhat.com> - 2017-08-09 20:40 +0200
      Re: [PATCH 2/2] mm, oom: fix potential data corruption when  oom_reaper races with writer Michal Hocko <mhocko@kernel.org> - 2017-08-10 10:30 +0200
        Re: [PATCH 2/2] mm, oom: fix potential data corruption when  oom_reaper races with writer Michal Hocko <mhocko@kernel.org> - 2017-08-10 15:40 +0200
    Re: [PATCH 2/2] mm, oom: fix potential data corruption when oom_reaper races with writer Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-08-11 04:30 +0200
      Re: [PATCH 2/2] mm, oom: fix potential data corruption when  oom_reaper races with writer Michal Hocko <mhocko@kernel.org> - 2017-08-11 09:10 +0200
        Re: [PATCH 2/2] mm, oom: fix potential data corruption when oom_reaper races with writer Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-08-11 10:00 +0200
          Re: [PATCH 2/2] mm, oom: fix potential data corruption when  oom_reaper races with writer Andrea Arcangeli <aarcange@redhat.com> - 2017-08-11 12:30 +0200
            Re: [PATCH 2/2] mm, oom: fix potential data corruption when  oom_reaper races with writer Andrea Arcangeli <aarcange@redhat.com> - 2017-08-11 12:50 +0200
          Re: [PATCH 2/2] mm, oom: fix potential data corruption when  oom_reaper races with writer Michal Hocko <mhocko@kernel.org> - 2017-08-11 14:10 +0200
            Re: [PATCH 2/2] mm, oom: fix potential data corruption when oom_reaper races with writer Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-08-11 17:50 +0200
  Re: [PATCH 0/2] mm, oom: fix oom_reaper fallouts Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-08-07 15:30 +0200
    Re: [PATCH 0/2] mm, oom: fix oom_reaper fallouts Michal Hocko <mhocko@kernel.org> - 2017-08-07 16:10 +0200
      Re: [PATCH 0/2] mm, oom: fix oom_reaper fallouts Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-08-07 17:30 +0200

csiph-web