Re: [PATCH] sym53c8xx: Avoid undefined behaviour in drivers/scsi/sym53c8xx_2/sym_hipd.c:762

From	Johannes Thumshirn <jthumshirn@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sym53c8xx: Avoid undefined behaviour in drivers/scsi/sym53c8xx_2/sym_hipd.c:762
Date	2017-08-11 09:30 +0200
Message-ID	<udcyl-A7-11@gated-at.bofh.it> (permalink)
References	<ud10e-1xP-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Aug 10, 2017 at 09:08:49PM +0200, Helge Deller wrote:
> On parisc I see this UBSAN warning with a sym53c896:
> 
>  UBSAN: Undefined behaviour in ./drivers/scsi/sym53c8xx_2/sym_hipd.c:762:24
>  index -1903078336 is out of range for type 'u32 [7]'
> 
> Avoid this warning by switching to dev64_ul().
                            div64_ul() ^

Otherwise,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>


-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] sym53c8xx: Avoid undefined behaviour in  drivers/scsi/sym53c8xx_2/sym_hipd.c:762 Helge Deller <deller@gmx.de> - 2017-08-10 21:10 +0200
  Re: [PATCH] sym53c8xx: Avoid undefined behaviour in  drivers/scsi/sym53c8xx_2/sym_hipd.c:762 Johannes Thumshirn <jthumshirn@suse.de> - 2017-08-11 09:30 +0200

csiph-web