Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1710448
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Boris Brezillon <boris.brezillon@free-electrons.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] mtd: nand: mtk: fix error return code in mtk_ecc_probe() |
| Date | Sun, 13 Aug 2017 10:10:02 +0200 |
| Message-ID | <udW8a-4E5-9@gated-at.bofh.it> (permalink) |
| References | <ucCXT-1Uf-9@gated-at.bofh.it> |
| X-Original-To | "Gustavo A. R. Silva" <gustavo@embeddedor.com> |
| X-Mailer | Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=UTF-8 |
| Content-Transfer-Encoding | 8BIT |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 38 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Richard Weinberger <richard@nod.at>, David Woodhouse <dwmw2@infradead.org>, Brian Norris <computersforpeace@gmail.com>, Marek Vasut <marek.vasut@gmail.com>, Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>, Matthias Brugger <matthias.bgg@gmail.com>, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Sun, 13 Aug 2017 10:02:12 +0200 |
| X-Original-Message-ID | <20170813100212.57ad0b65@bbrezillon> |
| X-Original-References | <20170809163521.GA4941@embeddedgus> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1710448 |
Show key headers only | View raw
Le Wed, 9 Aug 2017 11:35:21 -0500,
"Gustavo A. R. Silva" <gustavo@embeddedor.com> a écrit :
> platform_get_irq() returns an error code, but the mtk_ecc driver
> ignores it and always returns -EINVAL. This is not correct and,
> prevents -EPROBE_DEFER from being propagated properly.
>
> Print and propagate the return value of platform_get_irq on failure.
>
> This issue was detected with the help of Coccinelle.
Applied.
Thanks,
Boris
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/mtd/nand/mtk_ecc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/mtk_ecc.c b/drivers/mtd/nand/mtk_ecc.c
> index 6c3a4aa..7f3b065 100644
> --- a/drivers/mtd/nand/mtk_ecc.c
> +++ b/drivers/mtd/nand/mtk_ecc.c
> @@ -464,8 +464,8 @@ static int mtk_ecc_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(dev, "failed to get irq\n");
> - return -EINVAL;
> + dev_err(dev, "failed to get irq: %d\n", irq);
> + return irq;
> }
>
> ret = dma_set_mask(dev, DMA_BIT_MASK(32));
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] mtd: nand: mtk: fix error return code in mtk_ecc_probe() "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-08-09 19:30 +0200 Re: [PATCH] mtd: nand: mtk: fix error return code in mtk_ecc_probe() Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-08-13 10:10 +0200
csiph-web