Re: [PATCH v4 2/9] mtd: nand: sharpsl.h: support partition parser types

From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 2/9] mtd: nand: sharpsl.h: support partition parser types
Date	2017-08-13 09:50 +0200
Message-ID	<udVON-4gG-1@gated-at.bofh.it> (permalink)
References	<tXrUJ-29U-3@gated-at.bofh.it> <tXrUL-29U-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Le Wed, 28 Jun 2017 22:30:29 +0200,
Andrea Adami <andrea.adami@gmail.com> a écrit :

Please add a commit message explaining why you're doing that.

> Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> ---
>  include/linux/mtd/sharpsl.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/mtd/sharpsl.h b/include/linux/mtd/sharpsl.h
> index 65e91d0..c0e0be2 100644
> --- a/include/linux/mtd/sharpsl.h
> +++ b/include/linux/mtd/sharpsl.h
> @@ -17,4 +17,5 @@ struct sharpsl_nand_platform_data {
>  	const struct mtd_ooblayout_ops *ecc_layout;
>  	struct mtd_partition	*partitions;
>  	unsigned int		nr_partitions;
> +	const char *const	*types;	/* names of parsers to use if any */

types is not really descriptive here. How about 'part_parsers' or
something clearly reflecting the purpose of this field.

BTW, try to avoid putting comments on the same line.

>  };

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 2/9] mtd: nand: sharpsl.h: support partition parser  types Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-08-13 09:50 +0200
  Re: [PATCH v4 2/9] mtd: nand: sharpsl.h: support partition parser types Andrea Adami <andrea.adami@gmail.com> - 2017-08-14 15:50 +0200

csiph-web