[PATCH] tap: make struct tap_fops static

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH] tap: make struct tap_fops static
Date	2017-08-13 00:00 +0200
Message-ID	<udMBQ-6rM-11@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

The structure tap_fops is local to the source and does not need to
be in global scope, so make it static.

Cleans up sparse warning:
symbol 'tap_fops' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/tap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/tap.c b/drivers/net/tap.c
index ca267fd28ab8..0d039411e64c 100644
--- a/drivers/net/tap.c
+++ b/drivers/net/tap.c
@@ -1127,7 +1127,7 @@ static long tap_compat_ioctl(struct file *file, unsigned int cmd,
 }
 #endif
 
-const struct file_operations tap_fops = {
+static const struct file_operations tap_fops = {
 	.owner		= THIS_MODULE,
 	.open		= tap_open,
 	.release	= tap_release,
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] tap: make struct tap_fops static Colin King <colin.king@canonical.com> - 2017-08-13 00:00 +0200
  Re: [PATCH] tap: make struct tap_fops static David Miller <davem@davemloft.net> - 2017-08-14 05:20 +0200

csiph-web