Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1710354
| Path | csiph.com!news.redatomik.org!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
| Newsgroups | linux.kernel |
| Subject | [PATCH 3/3] ALSA: mpu401: Adjust four checks for null pointers |
| Date | Sat, 12 Aug 2017 21:20:02 +0200 |
| Message-ID | <udK70-4Y3-9@gated-at.bofh.it> (permalink) |
| References | <udK6Z-4Y3-5@gated-at.bofh.it> |
| User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=utf-8 |
| Content-Language | en-GB |
| Content-Transfer-Encoding | 8bit |
| X-Provags-ID | V03:K0:FYc/9o9gpKXtoj9zXeEtwxB2XkHgKW1NR3emL0DiPq/OmIwwiic 8U8D+q+QUdTS9ler+OD0jLZkgkQ1H+H018ui0z7AtSM0/Nt9XT6D2DtP8A0APKuIvtuH+VC FMeSm8gnPZlJAcG7idIhGwOmZP3p6cMdzfc0tF9INOW+TcKxRZYEcpQceFTJFSqzp7o3vxf uJuty0TEmwXSToXQ6jEGQ== |
| X-Ui-Out-Filterresults | notjunk:1;V01:K0:bpADMfWqyqc=:FGFlqPdH+BBUrzE2HSrHCq noqlbejz8xcJHL9wLOGS4sxnurkyoCvR+NbQ+LX8BP3fVLJ7n5/+e57jbpJJgAkxFAF+ZbCZ/ 1q8LN2TCC1NaLyHQ+c9DKOyRykqk8GOG7wWlzOJTG86e3QGcUFEd7E+BrCGKIfvBCmRRiE3KB prfC7i76aBzGkmrRwu85/O8yD0gcwFJ05l5sO2RH0DiWbcRYuzscLGDhfmESRJIQFomQYBoAS FysjdEpm5Mv/p5vEc8DxpFuaPLjn6N2sx0yLOu3tLprBZYdERwFnIoZax+fQSNZcCxaFnyKO5 04U8HEBKI2BVF3wfhzSgLLTZRxT2YSsD7Q+sAQD5/zoEduwozkKfim0oNXI1FSuelDmtooAOc aXrIWUhx5lBJ9IYP77VitckVL4rdqsxUvZptxbolCN9ldUnsgFYHF5ErUfSKLXu4euLRbE3dF /XPW+JBbaUG7qFMqyTOI8nOKnH6UkBklLpgQqiS2T4rLBdy5Ag7lJRytJMzNHnGPHVeZJlOCQ cGNjpxZymsPOe/eQVzOBXoEIpsw+8PPt5oE/3RninKlM6bc/Uj599X8v+YlFurhoPL2MtIrVv RPul+Ute1n8/vZVHGxsKiIFHAvcmvsNTlcAlhqBiHOpUjrk1HXO8jcl5s7OPpWZrbVQM4+TB9 qqod5wrLqdITYg3vFiLG84vgVSJLnX1Ae8rr79qMJdfMuIepS/+qQuwgIFIxv/byhyzUY8ovv bJW/9S/T2ESQ4Me+R5kY1/Q4+mJUmI6VDV8aIiP6Crm/zyjmGoPl5+/1RaPu+05e73cZjAPbr bbhagVRqJRBBJ34+hOIUZc5/dq3y0hNOpb4fTFjNH9FU/VO/N4= |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 59 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org |
| X-Original-Date | Sat, 12 Aug 2017 21:13:49 +0200 |
| X-Original-Message-ID | <c64cc0e7-2c9b-c4b7-77bd-daae455852ba@users.sourceforge.net> |
| X-Original-References | <47947226-bd09-5d15-c0d2-a9f4a659e1b4@users.sourceforge.net> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1710354 |
Show key headers only | View raw
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 12 Aug 2017 20:50:16 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written !…
Thus fix the affected source code places.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
sound/drivers/mpu401/mpu401_uart.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/drivers/mpu401/mpu401_uart.c b/sound/drivers/mpu401/mpu401_uart.c
index e8bdea193eab..b997222274bd 100644
--- a/sound/drivers/mpu401/mpu401_uart.c
+++ b/sound/drivers/mpu401/mpu401_uart.c
@@ -136,7 +136,7 @@ irqreturn_t snd_mpu401_uart_interrupt(int irq, void *dev_id)
{
struct snd_mpu401 *mpu = dev_id;
- if (mpu == NULL)
+ if (!mpu)
return IRQ_NONE;
_snd_mpu401_uart_interrupt(mpu);
return IRQ_HANDLED;
@@ -157,7 +157,7 @@ irqreturn_t snd_mpu401_uart_interrupt_tx(int irq, void *dev_id)
{
struct snd_mpu401 *mpu = dev_id;
- if (mpu == NULL)
+ if (!mpu)
return IRQ_NONE;
uart_interrupt_tx(mpu);
return IRQ_HANDLED;
@@ -544,7 +544,7 @@ int snd_mpu401_uart_new(struct snd_card *card, int device,
out_enable, in_enable, &rmidi)) < 0)
return err;
mpu = kzalloc(sizeof(*mpu), GFP_KERNEL);
- if (mpu == NULL) {
+ if (!mpu) {
err = -ENOMEM;
goto free_device;
}
@@ -558,7 +558,7 @@ int snd_mpu401_uart_new(struct snd_card *card, int device,
if (! (info_flags & MPU401_INFO_INTEGRATED)) {
int res_size = hardware == MPU401_HW_PC98II ? 4 : 2;
mpu->res = request_region(port, res_size, "MPU401 UART");
- if (mpu->res == NULL) {
+ if (!mpu->res) {
snd_printk(KERN_ERR "mpu401_uart: "
"unable to grab port 0x%lx size %d\n",
port, res_size);
--
2.14.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/3] ALSA: mpu401: Adjustments for three function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-12 21:20 +0200
[PATCH 2/3] ALSA: mpu401: Use common error handling code in snd_mpu401_uart_new() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-12 21:20 +0200
Re: [PATCH 2/3] ALSA: mpu401: Use common error handling code in snd_mpu401_uart_new() Joe Perches <joe@perches.com> - 2017-08-13 03:10 +0200
[PATCH 3/3] ALSA: mpu401: Adjust four checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-12 21:20 +0200
Re: [PATCH 0/3] ALSA: mpu401: Adjustments for three function implementations Takashi Iwai <tiwai@suse.de> - 2017-08-12 23:40 +0200
csiph-web