Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1710329

[PATCH] ALSA: pcxhr: Delete an error message for a failed memory allocation in pcxhr_create()

Show key headers only | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 12 Aug 2017 18:14:54 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 sound/pci/pcxhr/pcxhr.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/pci/pcxhr/pcxhr.c b/sound/pci/pcxhr/pcxhr.c
index fa919f52e225..376fd76caec2 100644
--- a/sound/pci/pcxhr/pcxhr.c
+++ b/sound/pci/pcxhr/pcxhr.c
@@ -1215,10 +1215,8 @@ static int pcxhr_create(struct pcxhr_mgr *mgr,
 	};
 
 	chip = kzalloc(sizeof(*chip), GFP_KERNEL);
-	if (! chip) {
-		dev_err(card->dev, "cannot allocate chip\n");
+	if (!chip)
 		return -ENOMEM;
-	}
 
 	chip->card = card;
 	chip->chip_idx = idx;
-- 
2.14.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] ALSA: pcxhr: Delete an error message for a failed memory  allocation in pcxhr_create() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-12 18:30 +0200
  Re: [PATCH] ALSA: pcxhr: Delete an error message for a failed memory allocation in pcxhr_create() Takashi Iwai <tiwai@suse.de> - 2017-08-12 23:40 +0200

csiph-web