Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1710279

[PATCH 1/3] ALSA: rme96: Delete two error messages for a failed memory allocation in snd_rme96_probe()

Path csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject [PATCH 1/3] ALSA: rme96: Delete two error messages for a failed memory allocation in snd_rme96_probe()
Date Sat, 12 Aug 2017 15:50:01 +0200
Message-ID <udEXD-1pb-7@gated-at.bofh.it> (permalink)
References <udENY-1ls-15@gated-at.bofh.it>
User-Agent Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1
MIME-Version 1.0
Content-Type text/plain; charset=utf-8
Content-Language en-GB
Content-Transfer-Encoding 8bit
X-Provags-ID V03:K0:OhGJsn4a7qw1ACabJxRgMloXbYn+Of3fCARGLfyYR/UZ7X7knXt 1yBtEf4CcjfZV7Bn630D45iCoJ52FKNJ+Lq+QFn4koUDQKQJ7nVdgzzTLRnDQswWYigI9uu Z/1vtl36Gy+mAwfQDLK7dB+TivBAHm1tSLu04zhdWeqEN69CSgMM6Pu9Gk3CKqKHdm0u32b RIRxIbeTYb8hcJl0oQ91g==
X-Ui-Out-Filterresults notjunk:1;V01:K0:MhcZqCUf+DA=:flBRQiAbXYls7bqoC1+lFE HZMXYK8wYbZX5K61H4/mUfcVTbc0UnOEF7n1ZVNjtl0P6SuAmX6DDl1VNnIK23aFeQSdjT3Mm 7OPAVSk5VykgrIBIqsHMpxL70zrSyIb1z3WlY8hYuE5LqzoLSy/dBPinIIbmtbA6bTMKuAXyY alllEeEmVV+qcA9WaKWZRYsMJt+oOnjPXPJoz5hReBz4vy2R2Wp2f0p1gBPRTwr6L58Waaip9 n0wyG5fkqtd2GKzre7LqP6CDWrpSXjga8WcM6ElkeYl0vOxLhng3INcbpNqP1zPplex8ejywX f7CNFzM3gW/94wknsbxr3emFk3+dJ1KPf2LuXIxEUBPjZf/lLpeCqsmU5hx13LROTTaFR7cWR nknTQlpQXxHP9Rxyl6qJR5XA0GuMmML5D0ygllB7b0+m4saLXnel1HKtmGs5MUpYwBb37+fDl va+9EKXrGGXpY0JHnHLCI4w6ppfIeNQLvD919LQNKzIPwK307z6i0NQiuSkxzZiBK0I0UaYjT YodHLMZgroqLCBbnZdeBPuk6JQwglsC2TxJEBHPaa9qq9/iQA/OAk4D4xTSPEsDMoLGiAq7Ti R7Ac9iC2gZhG8M1OMKrmnRmvsIoTRqEXQCySqNc8e2M7umwqyvrariklRLxJH0hyugy+N7yYL RM4yUmlpLTTQqhJVwxrT2qPMIywZ3QrFScbxZNM1achU3cJ5Ymbrz9gOkeTJrmAAqlEWVoi7U K4n9Tr5GGlXLZlTTvHZRhurWAssAj9eowr1gzAjmR9RelviQEF9H43lpUY6vADpUMwJUaf4a3 lLmPh5AbqavLxVR6IIjqqNFGszMLMZoU4RtFMrZD63qphY1ifk=
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 34
Organization linux.* mail to news gateway
X-Original-Cc LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
X-Original-Date Sat, 12 Aug 2017 15:40:06 +0200
X-Original-Message-ID <523430da-d833-28dc-58dd-ea95b9f04149@users.sourceforge.net>
X-Original-References <b38ee17e-f2ed-2bd7-6bc1-524ab4b3eb02@users.sourceforge.net>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1710279

Show key headers only | View raw


From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 12 Aug 2017 14:24:41 +0200

Omit extra messages for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 sound/pci/rme96.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/sound/pci/rme96.c b/sound/pci/rme96.c
index 2e19ba55e754..82e8c78e48ca 100644
--- a/sound/pci/rme96.c
+++ b/sound/pci/rme96.c
@@ -2489,15 +2489,11 @@ snd_rme96_probe(struct pci_dev *pci,
 #ifdef CONFIG_PM_SLEEP
 	rme96->playback_suspend_buffer = vmalloc(RME96_BUFFER_SIZE);
 	if (!rme96->playback_suspend_buffer) {
-		dev_err(card->dev,
-			   "Failed to allocate playback suspend buffer!\n");
 		snd_card_free(card);
 		return -ENOMEM;
 	}
 	rme96->capture_suspend_buffer = vmalloc(RME96_BUFFER_SIZE);
 	if (!rme96->capture_suspend_buffer) {
-		dev_err(card->dev,
-			   "Failed to allocate capture suspend buffer!\n");
 		snd_card_free(card);
 		return -ENOMEM;
 	}
-- 
2.14.0

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] ALSA: rme96: Adjustments for six function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-12 15:40 +0200
  [PATCH 1/3] ALSA: rme96: Delete two error messages for a failed  memory allocation in snd_rme96_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-12 15:50 +0200
  [PATCH 2/3] ALSA: rme96: Use common error handling code in  snd_rme96_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-12 15:50 +0200
  [PATCH 3/3] ALSA: rme96: Adjust five checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-12 15:50 +0200
  Re: [PATCH 0/3] ALSA: rme96: Adjustments for six function implementations Takashi Iwai <tiwai@suse.de> - 2017-08-12 23:30 +0200

csiph-web