Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1710233

Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()

From Mark Rutland <mark.rutland@arm.com>
Newsgroups linux.kernel
Subject Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one()
Date 2017-08-12 13:30 +0200
Message-ID <udCMa-8ux-9@gated-at.bofh.it> (permalink)
References <ucFsJ-3Hw-3@gated-at.bofh.it> <ucFCp-3KK-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Aug 09, 2017 at 02:07:49PM -0600, Tycho Andersen wrote:
> From: Juerg Haefliger <juerg.haefliger@hpe.com>
> 
> Add a hook for flushing a single TLB entry on arm64.
> 
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> Tested-by: Tycho Andersen <tycho@docker.com>
> ---
>  arch/arm64/include/asm/tlbflush.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h
> index af1c76981911..8e0c49105d3e 100644
> --- a/arch/arm64/include/asm/tlbflush.h
> +++ b/arch/arm64/include/asm/tlbflush.h
> @@ -184,6 +184,14 @@ static inline void flush_tlb_kernel_range(unsigned long start, unsigned long end
>  	isb();
>  }
>  
> +static inline void __flush_tlb_one(unsigned long addr)
> +{
> +	dsb(ishst);
> +	__tlbi(vaae1is, addr >> 12);
> +	dsb(ish);
> +	isb();
> +}

Is this going to be called by generic code?

It would be nice if we could drop 'kernel' into the name, to make it clear this
is intended to affect the kernel mappings, which have different maintenance
requirements to user mappings.

We should be able to implement this more simply as:

flush_tlb_kernel_page(unsigned long addr)
{
	flush_tlb_kernel_range(addr, addr + PAGE_SIZE);
}

Thanks,
Mark.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v5 00/10] Add support for eXclusive Page Frame Ownership Tycho Andersen <tycho@docker.com> - 2017-08-09 22:10 +0200
  [PATCH v5 07/10] arm64/mm: Don't flush the data cache if the page is unmapped by XPFO Tycho Andersen <tycho@docker.com> - 2017-08-09 22:10 +0200
    Re: [kernel-hardening] [PATCH v5 07/10] arm64/mm: Don't flush the  data cache if the page is unmapped by XPFO Mark Rutland <mark.rutland@arm.com> - 2017-08-12 14:00 +0200
      Re: [kernel-hardening] [PATCH v5 07/10] arm64/mm: Don't flush the  data cache if the page is unmapped by XPFO Mark Rutland <mark.rutland@arm.com> - 2017-08-14 19:00 +0200
      Re: [kernel-hardening] [PATCH v5 07/10] arm64/mm: Don't flush the  data cache if the page is unmapped by XPFO Tycho Andersen <tycho@docker.com> - 2017-08-14 22:30 +0200
        Re: [kernel-hardening] [PATCH v5 07/10] arm64/mm: Don't flush the  data cache if the page is unmapped by XPFO Mark Rutland <mark.rutland@arm.com> - 2017-08-15 11:50 +0200
  [PATCH v5 01/10] mm: add MAP_HUGETLB support to vm_mmap Tycho Andersen <tycho@docker.com> - 2017-08-09 22:20 +0200
  [PATCH v5 03/10] swiotlb: Map the buffer if it was unmapped by XPFO Tycho Andersen <tycho@docker.com> - 2017-08-09 22:20 +0200
    Re: [PATCH v5 03/10] swiotlb: Map the buffer if it was unmapped by  XPFO Konrad Rzeszutek Wilk <konrad@darnok.org> - 2017-08-10 15:10 +0200
      Re: [PATCH v5 03/10] swiotlb: Map the buffer if it was unmapped by  XPFO Tycho Andersen <tycho@docker.com> - 2017-08-10 18:30 +0200
  [PATCH v5 04/10] arm64: Add __flush_tlb_one() Tycho Andersen <tycho@docker.com> - 2017-08-09 22:20 +0200
    Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one() Mark Rutland <mark.rutland@arm.com> - 2017-08-12 13:30 +0200
      Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one() Tycho Andersen <tycho@docker.com> - 2017-08-14 18:40 +0200
        Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one() Mark Rutland <mark.rutland@arm.com> - 2017-08-14 19:00 +0200
          Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one() Tycho Andersen <tycho@docker.com> - 2017-08-14 19:10 +0200
          Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one() Tycho Andersen <tycho@docker.com> - 2017-08-23 19:00 +0200
            Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one() Mark Rutland <mark.rutland@arm.com> - 2017-08-23 19:10 +0200
              Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one() Tycho Andersen <tycho@docker.com> - 2017-08-23 19:20 +0200
                Re: [kernel-hardening] [PATCH v5 04/10] arm64: Add __flush_tlb_one() Mark Rutland <mark.rutland@arm.com> - 2017-08-24 17:50 +0200
  [PATCH v5 02/10] mm, x86: Add support for eXclusive Page Frame Ownership (XPFO) Tycho Andersen <tycho@docker.com> - 2017-08-09 22:20 +0200
    Re: [PATCH v5 02/10] mm, x86: Add support for eXclusive Page Frame  Ownership (XPFO) Laura Abbott <labbott@redhat.com> - 2017-08-14 21:00 +0200
    Re: [PATCH v5 02/10] mm, x86: Add support for eXclusive Page Frame  Ownership (XPFO) Laura Abbott <labbott@redhat.com> - 2017-08-15 00:40 +0200
      Re: [PATCH v5 02/10] mm, x86: Add support for eXclusive Page Frame  Ownership (XPFO) Tycho Andersen <tycho@docker.com> - 2017-08-15 05:50 +0200
        Re: [PATCH v5 02/10] mm, x86: Add support for eXclusive Page Frame  Ownership (XPFO) Tycho Andersen <tycho@docker.com> - 2017-08-15 06:00 +0200
  [PATCH v5 05/10] arm64/mm: Add support for XPFO Tycho Andersen <tycho@docker.com> - 2017-08-09 22:20 +0200
    Re: [kernel-hardening] [PATCH v5 05/10] arm64/mm: Add support for  XPFO Laura Abbott <labbott@redhat.com> - 2017-08-11 20:10 +0200
      Re: [kernel-hardening] [PATCH v5 05/10] arm64/mm: Add support for  XPFO Tycho Andersen <tycho@docker.com> - 2017-08-11 22:20 +0200
  Re: [kernel-hardening] [PATCH v5 00/10] Add support for eXclusive  Page Frame Ownership Laura Abbott <labbott@redhat.com> - 2017-08-12 01:40 +0200

csiph-web