Re: [PATCH 7/8] memory: mtk-smi: Rearrange some function position alphabetically

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Yong Wu <yong.wu@mediatek.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 7/8] memory: mtk-smi: Rearrange some function position alphabetically
Date	Sat, 12 Aug 2017 11:40:01 +0200
Message-ID	<udB3H-7jv-3@gated-at.bofh.it> (permalink)
References	<udeTw-1T8-7@gated-at.bofh.it> <udeTw-1T8-21@gated-at.bofh.it> <udmxI-6Oo-9@gated-at.bofh.it>
X-Original-To	Robin Murphy <robin.murphy@arm.com>
Content-Type	text/plain; charset="UTF-8"
X-Mailer	Evolution 3.2.3-0ubuntu6
Content-Transfer-Encoding	7bit
MIME-Version	1.0
X-Mtk	N
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	Joerg Roedel <joro@8bytes.org>, Rob Herring <robh+dt@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, Will Deacon <will.deacon@arm.com>, Daniel Kurtz <djkurtz@google.com>, Tomasz Figa <tfiga@google.com>, Mark Rutland <mark.rutland@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, <linux-mediatek@lists.infradead.org>, <srv_heupstream@mediatek.com>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <iommu@lists.linux-foundation.org>, <arnd@arndb.de>, <honghui.zhang@mediatek.com>, <k.zhang@mediatek.com>, <cloud.chou@mediatek.com>, Arvind Yadav <arvind.yadav.cs@gmail.com>, <youlin.pei@mediatek.com>
X-Original-Date	Sat, 12 Aug 2017 17:36:08 +0800
X-Original-Message-ID	<1502530568.11148.55.camel@mhfsdcap03>
X-Original-References	<1502445377-26936-1-git-send-email-yong.wu@mediatek.com> <1502445377-26936-8-git-send-email-yong.wu@mediatek.com> <34e9e7ec-ff9b-caf9-09ac-a0d9e9d85fa5@arm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1710209

Show key headers only | View raw

On Fri, 2017-08-11 at 19:09 +0100, Robin Murphy wrote:
> On 11/08/17 10:56, Yong Wu wrote:
> > Only adjust some code position in Soc numerical order, from mt2701,
> > mt2712 to mt8173.
> > 
> > Besides, 3 minor changes:
> > 1) fix a coding style issue:
> >     CHECK: Alignment should match open parenthesis
> >     +               writel(reg_val,
> >     +                       common->smi_ao_base
> > 2) change from readl to readl_relaxed in gen1_config_port.
> > 3) change the type "larbid" from "int" to "unsigned int" to meet
> >    the requirement of of_property_read_u32.
> 
> If moving existing code around is really necessary, do it as a
> preliminary patch *before* any material changes (and arguably separate
> even from the whitespace and comment updates) - those diffs are usually
> hard to review as-is, so being able to check you get binary-identical
> object files before and after is reassuring. A "cleanup" patch shouldn't
> need to touch code added in the same series, and it certainly shouldn't
> have significant things like the readl_relaxed() change hidden in it.

OK. This patch is really not easy to read.

This patch-set is mainly for supporting MT2712 IOMMU. thus, I will use a
patch "readl_relaxed replace readl" instead of this one.

About the cleanup patch, I can send it in future if necessary.

> 
> Robin.
> 
> > Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> > ---
> >  drivers/memory/mtk-smi.c | 105 +++++++++++++++++++++++------------------------
> >  1 file changed, 52 insertions(+), 53 deletions(-)
> > 
[...]

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 7/8] memory: mtk-smi: Rearrange some function position alphabetically Yong Wu <yong.wu@mediatek.com> - 2017-08-11 12:00 +0200
  Re: [PATCH 7/8] memory: mtk-smi: Rearrange some function position  alphabetically Robin Murphy <robin.murphy@arm.com> - 2017-08-11 20:10 +0200
    Re: [PATCH 7/8] memory: mtk-smi: Rearrange some function position  alphabetically Yong Wu <yong.wu@mediatek.com> - 2017-08-12 11:40 +0200

csiph-web