Re: [PATCH v2 2/2] dt-bindings: ata: add DT bindings for MediaTek SATA controller

From	Ryder Lee <ryder.lee@mediatek.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/2] dt-bindings: ata: add DT bindings for MediaTek SATA controller
Date	2017-08-11 06:00 +0200
Message-ID	<ud9h7-6MB-1@gated-at.bofh.it> (permalink)
References	<ubMZj-6zu-3@gated-at.bofh.it> <ubMZj-6zu-1@gated-at.bofh.it> <ud2IG-2zc-9@gated-at.bofh.it> <ud7S1-62F-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Rob,

Sorry for the noise letter.

On Fri, 2017-08-11 at 10:25 +0800, Ryder Lee wrote:
> > > +Required properties:
> > > + - compatible	   : Must be "mediatek,ahci".
> > 
> > SoC specific compatible strings please.
> 
> Okay.

I took a look at ./ahci-platform.txt. Could we just add a generic
compatible string as below:

compatible: Must be "mediatek,soc-model-ahci", "mediatek,mtk-ahci"

In doing so, we can avoid having an endless list of compatibles for
those MTK SoCs with the same IP block.

> > > +
> > > +Optional properties:
> > > + - power-domains   : A phandle and power domain specifier pair to the power
> > > +		     domain which is responsible for collapsing and restoring
> > > +		     power to the peripheral.
> > > + - resets	   : Must contain an entry for each entry in reset-names.
> > > +		     See ../reset/reset.txt for details.
> > > + - reset-names	   : Associated names must be: "axi", "sw", "reg".
> > > + - mediatek,phy-mode : A phandle to the system controller, used to enable
> > > +		       SATA function.
> > > +
> > > +Example:
> > > +
> > > +	sata: sata@1a200000 {
> > > +		compatible = "mediatek,ahci";

MT7622 should be:
               compatible = "mediatek,mt7622-ahci",
                            "mediatek,mtk-ahci";


Ryder

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 2/2] dt-bindings: ata: add DT bindings for MediaTek SATA controller Ryder Lee <ryder.lee@mediatek.com> - 2017-08-07 12:00 +0200
  Re: [PATCH v2 2/2] dt-bindings: ata: add DT bindings for MediaTek  SATA controller Rob Herring <robh@kernel.org> - 2017-08-10 23:00 +0200
    Re: [PATCH v2 2/2] dt-bindings: ata: add DT bindings for MediaTek  SATA controller Ryder Lee <ryder.lee@mediatek.com> - 2017-08-11 04:30 +0200
      Re: [PATCH v2 2/2] dt-bindings: ata: add DT bindings for MediaTek  SATA controller Ryder Lee <ryder.lee@mediatek.com> - 2017-08-11 06:00 +0200

csiph-web