Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1709168

Re: [PATCH v2 1/9] arm64: dts: hi3660: enable idle states

Show all headers | View raw

Hi Daniel,

On Thu, Aug 10, 2017 at 12:07:07PM +0200, Daniel Lezcano wrote:
> 
> Hi Guodong, Leo,
> 
> there are several typos in the patch description. I *humbly* propose an
> alternate description to make it a bit more English friendly.
> 
> """
> 
> There are two clusters on the Hi3660, the first one is Cortex-A53 based
> and the other one is Cortex-A73 based. These two clusters have different
> idle states.
> 
> Thanks to Daniel Lezcano's recent changes, the generic ARM cpuidle
> driver can now support several clusters with different idle states, thus
> supporting the big.Little architecture.
> 
> In addition to the WFI idle state which is the default shallowest state
> for all ARM cpus, the Hi3660 supports the following states:
> 
>  - CA53 CPUs:
> 	- CPU_SLEEP:       CPU power off state
> 	- CLUSTER_SLEEP_0: Cluster power off state
> 
>  - CA73 CPUs:
> 	- CPU_NAP:         CPU retention state
> 	- CPU_SLEEP:       CPU power off state
> 	- CLUSTER_SLEEP_1: Cluster power off state
> 
> This patch adds the idle states description for the Hi3660 to the device
> tree.
> 
> """
> 
> 
> Other than that.
> 
> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>

Thanks a lot for proposing commit log, it's much better :)

Thanks,
Leo Yan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/9] arm64: dts: hi3660: add more device nodes Guodong Xu <guodong.xu@linaro.org> - 2017-08-10 04:30 +0200
  [PATCH v2 3/9] arm64: dts: hi3660: add pmu dt node for hi3660 Guodong Xu <guodong.xu@linaro.org> - 2017-08-10 04:30 +0200
  [PATCH v2 6/9] arm64: dts: hikey960: Add pstore support Guodong Xu <guodong.xu@linaro.org> - 2017-08-10 04:30 +0200
  [PATCH v2 1/9] arm64: dts: hi3660: enable idle states Guodong Xu <guodong.xu@linaro.org> - 2017-08-10 04:30 +0200
    Re: [PATCH v2 1/9] arm64: dts: hi3660: enable idle states Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-08-10 12:10 +0200
      Re: [PATCH v2 1/9] arm64: dts: hi3660: enable idle states Leo Yan <leo.yan@linaro.org> - 2017-08-11 04:00 +0200
  [PATCH v2 9/9] arm64: dts: hi3660: add bindings for DMA Guodong Xu <guodong.xu@linaro.org> - 2017-08-10 04:30 +0200
  [PATCH v2 8/9] arm64: dts: hikey960: change bluetooth uart max-speed to 3mbps Guodong Xu <guodong.xu@linaro.org> - 2017-08-10 04:30 +0200
  [PATCH v2 2/9] arm64: dts: hi3660: add L2 cache topology Guodong Xu <guodong.xu@linaro.org> - 2017-08-10 04:30 +0200
  [PATCH v2 7/9] arm64: dts: hi3660: Reset the mmc hosts Guodong Xu <guodong.xu@linaro.org> - 2017-08-10 04:30 +0200
  [PATCH v2 4/9] arm64: dts: hikey960: Add optee node Guodong Xu <guodong.xu@linaro.org> - 2017-08-10 04:30 +0200

csiph-web