Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1709113

[PATCH 0/3] v4l2-compat-ioctl32.c: better detect pointer controls

Show all headers | View raw

In the past, only string controls were pointers. That changed when compounded
types got added, but the compat32 code was not updated.

We could just add those controls there, but maintaining it is flaw, as we
often forget about the compat code. So, instead, rely on the control type,
as this is always updated when new controls are added.

As both v4l2-ctrl and compat32 code are at videodev.ko module, we can
move the ctrl_is_pointer() helper function to v4l2-ctrl.c.

Mauro Carvalho Chehab (3):
  media: v4l2-ctrls.h: better document the arguments for v4l2_ctrl_fill
  media: v4l2-ctrls: prepare the function to be used by compat32 code
  media: compat32: reimplement ctrl_is_pointer()

 drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 18 +---------
 drivers/media/v4l2-core/v4l2-ctrls.c          | 49 +++++++++++++++++++++++++--
 include/media/v4l2-ctrls.h                    | 28 ++++++++++-----
 3 files changed, 67 insertions(+), 28 deletions(-)

-- 
2.13.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] v4l2-compat-ioctl32.c: better detect pointer controls Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2017-08-11 01:50 +0200
  [PATCH 2/3] media: v4l2-ctrls: prepare the function to be used by compat32 code Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2017-08-11 01:50 +0200
  [PATCH 3/3] media: compat32: reimplement ctrl_is_pointer() Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2017-08-11 01:50 +0200
  Re: [PATCH 0/3] v4l2-compat-ioctl32.c: better detect pointer  controls Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2017-08-11 02:00 +0200

csiph-web