Re: [PATCH] auxdisplay: img-ascii-lcd: Only build on archs that have IOMEM

From	Randy Dunlap <rdunlap@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] auxdisplay: img-ascii-lcd: Only build on archs that have IOMEM
Date	2017-08-10 20:30 +0200
Message-ID	<ud0nx-ME-35@gated-at.bofh.it> (permalink)
References	<ucRtU-323-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/10/2017 01:53 AM, Thomas Meyer wrote:
> This avoids the MODPOST error:
> ERROR: "devm_ioremap_resource" [drivers/auxdisplay/img-ascii-lcd.ko] undefined!
> 
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
>  drivers/auxdisplay/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> index 9ae6681c90ad..9088c66e4c08 100644
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -135,6 +135,7 @@ config CFAG12864B_RATE
>  
>  config IMG_ASCII_LCD
>  	tristate "Imagination Technologies ASCII LCD Display"
> +	depends on HAS_IOMEM
>  	default y if MIPS_MALTA || MIPS_SEAD3
>  	select SYSCON
>  	help
> 

I posted the same patch on 2017-JAN-01, so I agree with it.

https://lkml.org/lkml/2017/1/1/87

Acked-by: Randy Dunlap <rdunlap@infradead.org>

-- 
~Randy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] auxdisplay: img-ascii-lcd: Only build on archs that have IOMEM Thomas Meyer <thomas@m3y3r.de> - 2017-08-10 11:00 +0200
  Re: [PATCH] auxdisplay: img-ascii-lcd: Only build on archs that have  IOMEM Randy Dunlap <rdunlap@infradead.org> - 2017-08-10 20:30 +0200

csiph-web