Re: [PATCH 13/16] perf: Add a speculative page fault sw events

From	Laurent Dufour <ldufour@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 13/16] perf: Add a speculative page fault sw events
Date	2017-08-09 15:30 +0200
Message-ID	<uczdD-7A3-9@gated-at.bofh.it> (permalink)
References	<ucdPQ-1fE-5@gated-at.bofh.it> <ucdPQ-1fE-23@gated-at.bofh.it> <ucz3X-7wj-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/08/2017 15:18, Michael Ellerman wrote:
> Laurent Dufour <ldufour@linux.vnet.ibm.com> writes:
> 
>> Add new software events to count succeeded and failed speculative page
>> faults.
>>
>> Signed-off-by: Laurent Dufour <ldufour@linux.vnet.ibm.com>
>> ---
>>  include/uapi/linux/perf_event.h | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
>> index b1c0b187acfe..fbfb03dff334 100644
>> --- a/include/uapi/linux/perf_event.h
>> +++ b/include/uapi/linux/perf_event.h
>> @@ -111,6 +111,8 @@ enum perf_sw_ids {
>>  	PERF_COUNT_SW_EMULATION_FAULTS		= 8,
>>  	PERF_COUNT_SW_DUMMY			= 9,
>>  	PERF_COUNT_SW_BPF_OUTPUT		= 10,
>> +	PERF_COUNT_SW_SPF_DONE			= 11,
>> +	PERF_COUNT_SW_SPF_FAILED		= 12,
> 
> Can't you calculate:
> 
>   PERF_COUNT_SW_SPF_FAILED = PERF_COUNT_SW_PAGE_FAULTS - PERF_COUNT_SW_SPF_DONE
> 
> ie. do you need a separate event for it?

Unfortunately not, because PERF_COUNT_SW_PAGE_FAULTS counts also page
faults from the kernel space, while SPF is only concerning user space page
faults.

Cheers,
Laurent.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 13/16] perf: Add a speculative page fault sw events Laurent Dufour <ldufour@linux.vnet.ibm.com> - 2017-08-08 16:40 +0200
  Re: [PATCH 13/16] perf: Add a speculative page fault sw events Michael Ellerman <mpe@ellerman.id.au> - 2017-08-09 15:20 +0200
    Re: [PATCH 13/16] perf: Add a speculative page fault sw events Laurent Dufour <ldufour@linux.vnet.ibm.com> - 2017-08-09 15:30 +0200

csiph-web