Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1707043
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH][next] net: phy: mdio-bcm-unimac: fix unsigned wrap-around when decrementing timeout |
| Date | 2017-08-09 06:10 +0200 |
| Message-ID | <ucqtH-1Fl-11@gated-at.bofh.it> (permalink) |
| References | <uc9sS-6dC-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Colin King <colin.king@canonical.com>
Date: Tue, 8 Aug 2017 10:52:32 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Change post-decrement compare to pre-decrement to avoid an
> unsigned integer wrap-around on timeout. This leads to the following
> !timeout check to never to be true so -ETIMEDOUT is never returned.
>
> Detected by CoverityScan, CID#1452623 ("Logically dead code")
>
> Fixes: 69a60b0579a4 ("net: phy: mdio-bcm-unimac: factor busy polling loop")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH][next] net: phy: mdio-bcm-unimac: fix unsigned wrap-around when decrementing timeout Colin King <colin.king@canonical.com> - 2017-08-08 12:00 +0200 Re: [PATCH][next] net: phy: mdio-bcm-unimac: fix unsigned wrap-around when decrementing timeout David Miller <davem@davemloft.net> - 2017-08-09 06:10 +0200
csiph-web