Re: [PATCH V3 net-next 03/21] net-next/hinic: Initialize api cmd resources

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH V3 net-next 03/21] net-next/hinic: Initialize api cmd resources
Date	2017-08-08 19:10 +0200
Message-ID	<ucgaZ-2XK-9@gated-at.bofh.it> (permalink)
References	<ualou-6Yh-25@gated-at.bofh.it> <uawWC-6uI-33@gated-at.bofh.it> <ucfyi-2uV-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Aviad Krawczyk <aviad.krawczyk@huawei.com>
Date: Tue, 8 Aug 2017 19:23:32 +0300

> Is it a new rule?

It's at least 10 years old.

> We can fix it, but I can look over the Linux Kernel source and there are
> a lot of examples that have the same problem.

Stop right there.

Just because there is code in the kernel with a problem doesn't mean
you can submit new code with that problem.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V3 net-next 00/21] Huawei HiNIC Ethernet Driver Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-03 12:00 +0200
  [PATCH V3 net-next 15/21] net-next/hinic: Add ceqs Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-03 12:00 +0200
  [PATCH V3 net-next 04/21] net-next/hinic: Initialize api cmd hw Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-03 12:00 +0200
  [PATCH V3 net-next 20/21] net-next/hinic: Add ethtool and stats Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-03 12:10 +0200
  [PATCH V3 net-next 19/21] net-next/hinic: Add Tx operation Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-03 12:10 +0200
  [PATCH V3 net-next 21/21] net-next/hinic: Add select_queue and netpoll Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-03 12:10 +0200
  [PATCH V3 net-next 06/21] net-next/hinic: Add api cmd commands Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-03 12:20 +0200
  [PATCH V3 net-next 05/21] net-next/hinic: Add management messages Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-03 12:20 +0200
  [PATCH V3 net-next 03/21] net-next/hinic: Initialize api cmd resources Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-03 12:20 +0200
    Re: [PATCH V3 net-next 03/21] net-next/hinic: Initialize api cmd  resources David Miller <davem@davemloft.net> - 2017-08-04 00:40 +0200
      Re: [PATCH V3 net-next 03/21] net-next/hinic: Initialize api cmd  resources Aviad Krawczyk <aviad.krawczyk@huawei.com> - 2017-08-08 18:30 +0200
        Re: [PATCH V3 net-next 03/21] net-next/hinic: Initialize api cmd  resources David Miller <davem@davemloft.net> - 2017-08-08 19:10 +0200

csiph-web