Re: [PATCH v2 2/3] arm/syscalls: Optimize address limit check

From	Thomas Garnier <thgarnie@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/3] arm/syscalls: Optimize address limit check
Date	2017-08-08 18:10 +0200
Message-ID	<ucfeX-2nP-47@gated-at.bofh.it> (permalink)
References	<u7xYS-37A-7@gated-at.bofh.it> <u7xYS-37A-5@gated-at.bofh.it> <ubUat-3mF-3@gated-at.bofh.it> <ubUkb-3qL-41@gated-at.bofh.it> <ubUtP-3uU-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 7, 2017 at 10:55 AM, Russell King - ARM Linux
<linux@armlinux.org.uk> wrote:
>
> It's better in so far as it avoids the problems previously highlighted.
>
> However, it depends how efficient we want these paths to be - the
> difference between your assembly and the assembly I've previously
> supplied is that mine fills in any delay slots with some useful work
> and avoids adding extra delay slots in this path.

The previous assembly implementation we did was design as you
described but all checks were done after the pending work was managed.
I would like the address limit check to be done before, especially if
we move from panic to a SIGKILL approach.

>
> Arguably, the system call exit path is as important as the system
> call entry path for OS performance, so I think we should strive to
> make it as efficient as possible - much as I already did when I
> posted code on this topic previously.

How do you think it could improve while keeping the check before pending work?

>
> I think that code can simply be adapted to call your C function
> instead of the assembly "addr_limit_fail" label.

I don't use the label anymore on this version.

>
> --
> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
> According to speedtest.net: 8.21Mbps down 510kbps up



-- 
Thomas

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/3] arm/syscalls: Optimize address limit check Kees Cook <keescook@chromium.org> - 2017-08-07 19:40 +0200
  Re: [PATCH v2 2/3] arm/syscalls: Optimize address limit check Thomas Garnier <thgarnie@google.com> - 2017-08-07 19:50 +0200
    Re: [PATCH v2 2/3] arm/syscalls: Optimize address limit check Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-08-07 20:00 +0200
      Re: [PATCH v2 2/3] arm/syscalls: Optimize address limit check Thomas Garnier <thgarnie@google.com> - 2017-08-08 18:10 +0200

csiph-web