Re: blk-mq breaks suspend even with runtime PM patch

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: blk-mq breaks suspend even with runtime PM patch
Date	2017-08-08 18:50 +0200
Message-ID	<ucfRD-2BI-7@gated-at.bofh.it> (permalink)
References	<u8C0p-4ck-1@gated-at.bofh.it> <u8ONY-4sH-3@gated-at.bofh.it> <u8WVc-11e-13@gated-at.bofh.it> <ucfyj-2uV-41@gated-at.bofh.it> <ucfHX-2yd-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 08, 2017 at 06:34:01PM +0200, Mike Galbraith wrote:
> On Tue, 2017-08-08 at 09:22 -0700, Greg KH wrote:
> > On Sun, Jul 30, 2017 at 03:50:15PM +0200, Oleksandr Natalenko wrote:
> > > Hello Mike et al.
> > > 
> > > On neděle 30. července 2017 7:12:31 CEST Mike Galbraith wrote:
> > > > FWIW, first thing I'd do is update that 4.12.0 to 4.12.4, and see if
> > > > stable fixed it.
> > > 
> > > My build already includes v4.12.4.
> > > 
> > > > If not, I'd find these two commits irresistible.
> > > > 
> > > > 5f042e7cbd9eb blk-mq: Include all present CPUs in the default queue mapping
> > > > 4b855ad37194f blk-mq: Create hctx for each present CPU
> > > 
> > > I've applied these 2 commits, and cannot reproduce the issue anymore. Looks 
> > > like a perfect hit, thanks!
> > > 
> > > > 'course applying random upstream bits does come with some risk, trying
> > > > a kernel already containing them has less "entertainment" potential. 
> > > 
> > > Should you consider applying them to v4.12.x stable series? CC'ing Greg just 
> > > in case.
> > 
> > I can queue these up if I get an ack from the developers/maintainers
> > that it is ok to do so...
> > 
> > {hint}
> 
> {hint++}
> 
> Those commits take Steven Rostedt's hotplug stress script runtime down
> from 4 _minutes_ down to 7 seconds for my RT tree, so I'm rather hoping
> you hear an "ACK" too.

Oh, nice!

Should these go back farther than 4.12?  Looks like they apply cleanly
to 4.9, didn't look older than that...

thanks,

greg k-h

Thread

Re: blk-mq breaks suspend even with runtime PM patch Greg KH <gregkh@linuxfoundation.org> - 2017-08-08 18:30 +0200
  Re: blk-mq breaks suspend even with runtime PM patch Mike Galbraith <efault@gmx.de> - 2017-08-08 18:40 +0200
    Re: blk-mq breaks suspend even with runtime PM patch Greg KH <gregkh@linuxfoundation.org> - 2017-08-08 18:50 +0200
      Re: blk-mq breaks suspend even with runtime PM patch Mike Galbraith <efault@gmx.de> - 2017-08-08 19:00 +0200
        Re: blk-mq breaks suspend even with runtime PM patch Mike Galbraith <efault@gmx.de> - 2017-08-08 20:40 +0200
          Re: blk-mq breaks suspend even with runtime PM patch Jens Axboe <axboe@kernel.dk> - 2017-08-08 20:40 +0200
  Re: blk-mq breaks suspend even with runtime PM patch Jens Axboe <axboe@kernel.dk> - 2017-08-08 18:40 +0200
    Re: blk-mq breaks suspend even with runtime PM patch Oleksandr Natalenko <oleksandr@natalenko.name> - 2017-08-08 18:40 +0200
      Re: blk-mq breaks suspend even with runtime PM patch Greg KH <gregkh@linuxfoundation.org> - 2017-08-08 18:50 +0200
        Re: blk-mq breaks suspend even with runtime PM patch Oleksandr Natalenko <oleksandr@natalenko.name> - 2017-08-08 18:50 +0200

csiph-web