Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1706630

[PATCH 0/3 v2] thermal: core: Fix some error handling code in 'thermal_zone_device_register()'

Show all headers | View raw

These patches fix some issue in the error handling path in
'thermal_zone_device_register()'

The first patch adds some new helper function in order to ease the resource
management.
Maybe using devm_ variant could also be a better choise to free manage
these resources. As it would be a bigger change, I've not looked at it at
all at the moment.
Also, note that this patch triggers a checkpatch warning about missing
identifier name in function definition. I've left it as is to keep the
style of the .h file.

The 2nd patch makes use of the new helper function.

The 3rd patch reorders the error handling path of
'thermal_zone_device_register()' in order to avoid the leaks.

*** These patches have been compiled tested only. ***

I also unsure about the right place for 'ida_simple_remove' in patch 3/3.


v1 -> v2:
    - add some helper functions in order to release some resources more
      easily
    - split the error handling path into 2. One before a successful call to
      'device_register()', and one after


Christophe JAILLET (3):
  thermal: core: Add some new helper functions to free resources
  thermal: core: Use the new 'thermal_zone_destroy_device_groups()'
    helper function
  thermal: core: Fix resources release in error paths in
    thermal_zone_device_register()

 drivers/thermal/thermal_core.c  | 29 ++++++++++++++---------------
 drivers/thermal/thermal_core.h  |  1 +
 drivers/thermal/thermal_sysfs.c | 29 +++++++++++++++++++++++++++++
 3 files changed, 44 insertions(+), 15 deletions(-)

-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3 v2] thermal: core: Fix some error handling code in 'thermal_zone_device_register()' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-08-08 16:50 +0200
  [PATCH 1/3 v2] thermal: core: Add some new helper functions to free resources Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-08-08 16:50 +0200
    Re: [PATCH 1/3 v2] thermal: core: Add some new helper functions to  free resources Zhang Rui <rui.zhang@intel.com> - 2017-08-11 05:30 +0200
      Re: [PATCH 1/3 v2] thermal: core: Add some new helper functions to  free resources Zhang Rui <rui.zhang@intel.com> - 2017-08-11 05:40 +0200
    Re: [PATCH 1/3 v2] thermal: core: Add some new helper functions to  free resources walter harms <wharms@bfs.de> - 2017-08-11 09:40 +0200
      Re: [PATCH 1/3 v2] thermal: core: Add some new helper functions to  free resources Zhang Rui <rui.zhang@intel.com> - 2017-08-11 10:30 +0200
  [PATCH 2/3 v2] thermal: core: Use the new 'thermal_zone_destroy_device_groups()' helper function Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-08-08 16:50 +0200

csiph-web