Re: [PATCH 6/6] [media] uvcvideo: constify video_subdev structures

From	Julia Lawall <julia.lawall@lip6.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/6] [media] uvcvideo: constify video_subdev structures
Date	2017-08-08 15:00 +0200
Message-ID	<ucch5-8wk-29@gated-at.bofh.it> (permalink)
References	<ucaRX-7FO-9@gated-at.bofh.it> <ucaRZ-7FO-39@gated-at.bofh.it> <ucc7o-8sm-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On Tue, 8 Aug 2017, Laurent Pinchart wrote:

> Hi Julia,
>
> Thank you for the patch.
>
> On Tuesday 08 Aug 2017 12:58:32 Julia Lawall wrote:
> > uvc_subdev_ops is only passed as the second argument of
> > v4l2_subdev_init, which is const, so uvc_subdev_ops can be
> > const as well.
> >
> > Done with the help of Coccinelle.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> and applied to my tree (with the first word of the commit message after the
> prefix capitalized to match the rest of the driver's commit messages, let me
> know if that's a problem :-)).

No, of course not.  I will try to watch out for that in the future.

julia

> >
> > ---
> >  drivers/media/usb/uvc/uvc_entity.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/usb/uvc/uvc_entity.c
> > b/drivers/media/usb/uvc/uvc_entity.c index ac386bb..554063c 100644
> > --- a/drivers/media/usb/uvc/uvc_entity.c
> > +++ b/drivers/media/usb/uvc/uvc_entity.c
> > @@ -61,7 +61,7 @@ static int uvc_mc_create_links(struct uvc_video_chain
> > *chain, return 0;
> >  }
> >
> > -static struct v4l2_subdev_ops uvc_subdev_ops = {
> > +static const struct v4l2_subdev_ops uvc_subdev_ops = {
> >  };
> >
> >  void uvc_mc_cleanup_entity(struct uvc_entity *entity)
>
> --
> Regards,
>
> Laurent Pinchart
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 6/6] [media] uvcvideo: constify video_subdev structures Julia Lawall <Julia.Lawall@lip6.fr> - 2017-08-08 13:30 +0200
  Re: [PATCH 6/6] [media] uvcvideo: constify video_subdev structures Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-08-08 14:50 +0200
    Re: [PATCH 6/6] [media] uvcvideo: constify video_subdev structures Julia Lawall <julia.lawall@lip6.fr> - 2017-08-08 15:00 +0200

csiph-web