Re: suspicious __GFP_NOMEMALLOC in selinux

From	Paul Moore <paul@paul-moore.com>
Newsgroups	linux.kernel
Subject	Re: suspicious __GFP_NOMEMALLOC in selinux
Date	2017-08-08 15:40 +0200
Message-ID	<uccTL-z0-5@gated-at.bofh.it> (permalink)
References	(6 earlier) <uamaR-7y1-5@gated-at.bofh.it> <uasSZ-3Ii-1@gated-at.bofh.it> <uaFGx-4bb-3@gated-at.bofh.it> <uaOqt-1tl-15@gated-at.bofh.it> <ubKb8-4Nl-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 7, 2017 at 2:58 AM, Michal Hocko <mhocko@kernel.org> wrote:
> On Fri 04-08-17 13:12:04, Paul Moore wrote:
>> On Fri, Aug 4, 2017 at 3:56 AM, Michal Hocko <mhocko@kernel.org> wrote:
> [...]
>> > Btw. Should I resend the patch or somebody will take it from this email
>> > thread?
>>
>> No, unless your mailer mangled the patch I should be able to pull it
>> from this thread.  However, I'm probably going to let this sit until
>> early next week on the odd chance that anyone else wants to comment on
>> the flag choice.  I'll send another reply once I merge the patch.
>
> OK, there is certainly no hurry for merging this. Thanks!
> --
> Michal Hocko
> SUSE Labs

Merged into selinux/next with this patch description, and your
sign-off (I had to munge the description a bit based on the thread).
Are you okay with this, especially your sign-off?

  commit 476accbe2f6ef69caeebe99f52a286e12ac35aee
  Author: Michal Hocko <mhocko@kernel.org>
  Date:   Thu Aug 3 10:11:52 2017 +0200

   selinux: use GFP_NOWAIT in the AVC kmem_caches

   There is a strange __GFP_NOMEMALLOC usage pattern in SELinux,
   specifically GFP_ATOMIC | __GFP_NOMEMALLOC which doesn't make much
   sense.  GFP_ATOMIC on its own allows to access memory reserves while
   __GFP_NOMEMALLOC dictates we cannot use memory reserves.  Replace this
   with the much more sane GFP_NOWAIT in the AVC code as we can tolerate
   memory allocation failures in that code.

   Signed-off-by: Michal Hocko <mhocko@kernel.org>
   Acked-by: Mel Gorman <mgorman@suse.de>
   Signed-off-by: Paul Moore <paul@paul-moore.com>

-- 
paul moore
www.paul-moore.com

Thread

suspicious __GFP_NOMEMALLOC in selinux Michal Hocko <mhocko@kernel.org> - 2017-08-02 13:00 +0200
  Re: suspicious __GFP_NOMEMALLOC in selinux Paul Moore <pmoore@redhat.com> - 2017-08-02 23:50 +0200
    Re: suspicious __GFP_NOMEMALLOC in selinux Michal Hocko <mhocko@kernel.org> - 2017-08-03 10:20 +0200
      Re: suspicious __GFP_NOMEMALLOC in selinux Mel Gorman <mgorman@suse.de> - 2017-08-03 11:00 +0200
      Re: suspicious __GFP_NOMEMALLOC in selinux Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-08-03 12:10 +0200
        Re: suspicious __GFP_NOMEMALLOC in selinux Michal Hocko <mhocko@kernel.org> - 2017-08-03 12:40 +0200
          Re: suspicious __GFP_NOMEMALLOC in selinux Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2017-08-03 12:50 +0200
            Re: suspicious __GFP_NOMEMALLOC in selinux Michal Hocko <mhocko@kernel.org> - 2017-08-03 13:10 +0200
              Re: suspicious __GFP_NOMEMALLOC in selinux Paul Moore <paul@paul-moore.com> - 2017-08-03 20:20 +0200
                Re: suspicious __GFP_NOMEMALLOC in selinux Michal Hocko <mhocko@kernel.org> - 2017-08-04 10:00 +0200
                Re: suspicious __GFP_NOMEMALLOC in selinux Paul Moore <paul@paul-moore.com> - 2017-08-04 19:20 +0200
                Re: suspicious __GFP_NOMEMALLOC in selinux Michal Hocko <mhocko@kernel.org> - 2017-08-07 09:00 +0200
                Re: suspicious __GFP_NOMEMALLOC in selinux Paul Moore <paul@paul-moore.com> - 2017-08-08 15:40 +0200
                Re: suspicious __GFP_NOMEMALLOC in selinux Michal Hocko <mhocko@kernel.org> - 2017-08-10 09:10 +0200
                Re: suspicious __GFP_NOMEMALLOC in selinux Paul Moore <paul@paul-moore.com> - 2017-08-10 15:50 +0200

csiph-web