Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1706542

Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has BDI_CAP_SYNC capability

From Matthew Wilcox <willy@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has BDI_CAP_SYNC capability
Date 2017-08-08 15:30 +0200
Message-ID <uccK5-va-1@gated-at.bofh.it> (permalink)
References <uc6EG-4gz-3@gated-at.bofh.it> <uc6EF-4gz-1@gated-at.bofh.it> <ucch5-8wk-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Aug 08, 2017 at 05:49:59AM -0700, Matthew Wilcox wrote:
> +	struct bio sbio;
> +	struct bio_vec sbvec;

... this needs to be sbvec[nr_pages], of course.

> -		bio = mpage_alloc(bdev, blocks[0] << (blkbits - 9),
> +		if (bdi_cap_synchronous_io(inode_to_bdi(inode))) {
> +			bio = &sbio;
> +			bio_init(bio, &sbvec, nr_pages);

... and this needs to be 'sbvec', not '&sbvec'.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v1 2/6] fs: use on-stack-bio if backing device has BDI_CAP_SYNC capability Minchan Kim <minchan@kernel.org> - 2017-08-08 09:00 +0200
  Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has  BDI_CAP_SYNC capability Matthew Wilcox <willy@infradead.org> - 2017-08-08 15:00 +0200
    Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has  BDI_CAP_SYNC capability Matthew Wilcox <willy@infradead.org> - 2017-08-08 15:30 +0200
      Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has  BDI_CAP_SYNC capability Minchan Kim <minchan@kernel.org> - 2017-08-09 04:00 +0200
        Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has  BDI_CAP_SYNC capability Minchan Kim <minchan@kernel.org> - 2017-08-09 04:50 +0200
          Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has  BDI_CAP_SYNC capability Matthew Wilcox <willy@infradead.org> - 2017-08-10 05:10 +0200
            Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has  BDI_CAP_SYNC capability Dan Williams <dan.j.williams@intel.com> - 2017-08-10 05:10 +0200
              Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has         BDI_CAP_SYNC capability Christoph Hellwig <hch@lst.de> - 2017-08-11 12:50 +0200
                Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has  BDI_CAP_SYNC capability Jens Axboe <axboe@kernel.dk> - 2017-08-11 16:30 +0200
            Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has  BDI_CAP_SYNC capability Minchan Kim <minchan@kernel.org> - 2017-08-10 06:10 +0200
        Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has  BDI_CAP_SYNC capability Matthew Wilcox <willy@infradead.org> - 2017-08-09 05:40 +0200
    Re: [PATCH v1 2/6] fs: use on-stack-bio if backing device has  BDI_CAP_SYNC capability Minchan Kim <minchan@kernel.org> - 2017-08-09 03:50 +0200

csiph-web